Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: top-level data: URLs #17730

Merged
merged 2 commits into from
Feb 18, 2020
Merged

HTML: top-level data: URLs #17730

merged 2 commits into from
Feb 18, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented Jul 9, 2019

What is the exact behavior that we want here?

Firefox behavior of closing the popups makes some sense to me and could be explained through COOP. In that the data: URL acts as if it creates a new browsing context group (which we then error and leave up to the user agent to figure out UX for).

cc @cdumez @mystor @natechapin @domenic @mikewest @JuniorHsu

@annevk
Copy link
Member Author

annevk commented Jul 9, 2019

Any other scenarios that might need tests?

@mystor
Copy link
Contributor

mystor commented Jul 15, 2019

Any other scenarios that might need tests?

We should probably also test with window.open("...", "", "noopener"); as well as using <a href="..." rel="{opener,noopener}">

@annevk
Copy link
Member Author

annevk commented Jan 13, 2020

I did for window.open(). It seems hard to create pass conditions for <a>.

@jgraham does WebDriver allow you to make assertions about the number of open tabs and what URLs they point to?

@annevk annevk force-pushed the annevk/top-level-data-urls branch from 03a5491 to f1d06fc Compare January 13, 2020 15:09
@jgraham
Copy link
Contributor

jgraham commented Jan 13, 2020

It does, but I don't think our testdriver abstraction exposes the list of window handles or provides the ability to switch to another window. So implementing this at the moment would be quite a bit of work.

@gsnedders gsnedders closed this Jan 24, 2020
@gsnedders gsnedders deleted the annevk/top-level-data-urls branch January 24, 2020 18:01
@gsnedders gsnedders restored the annevk/top-level-data-urls branch January 24, 2020 18:40
@Hexcles Hexcles reopened this Jan 24, 2020
@annevk
Copy link
Member Author

annevk commented Feb 5, 2020

@domenic @ParisMeuleman @hemeryar what do you think?

@domenic
Copy link
Member

domenic commented Feb 6, 2020

I'd like to defer to @ParisMeuleman @hemeryar, who are much more in the guts of our COOP/popup code and spec space than I am at the moment.

@annevk
Copy link
Member Author

annevk commented Feb 7, 2020

To be clear, this isn't really about COOP, this is mostly about navigating to data URLs in a top-level browsing context failing (and if these tests seem okay, adding a corresponding change to the HTML Standard).

Copy link
Contributor

@ParisMeuleman ParisMeuleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here... those changes make sense to me, thanks for adding those!
But I must admit that I'm not well versed in data urls!

annevk added a commit to whatwg/html that referenced this pull request Feb 12, 2020
@annevk
Copy link
Member Author

annevk commented Feb 12, 2020

Thanks, created whatwg/html#5279 to complement this.

annevk added a commit to whatwg/html that referenced this pull request Feb 12, 2020
@annevk annevk merged commit 8e19fa6 into master Feb 18, 2020
@annevk annevk deleted the annevk/top-level-data-urls branch February 18, 2020 14:47
elkurin pushed a commit to elkurin/html that referenced this pull request Mar 11, 2020
@Aleksey-D-F

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants