Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a couple more test cases to urltestdata.txt #1819

Merged
merged 1 commit into from
May 23, 2015

Conversation

frewsxcv
Copy link
Member

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4963

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@frewsxcv
Copy link
Member Author

Dont merge this yet, I actually have a couple more to add

@frewsxcv frewsxcv changed the title Add another test case to urltestdata.txt Add a couple more test cases to urltestdata.txt May 11, 2015
@frewsxcv
Copy link
Member Author

Okay, should be ready to go

@sideshowbarker
Copy link
Contributor

For future reference, please don't squash/rebase on review branches (for one reason, because the external "critic" code-review system we use isn't smart enough to deal with it as expected)

sideshowbarker added a commit that referenced this pull request May 23, 2015
Add a couple more test cases to urltestdata.txt
@sideshowbarker sideshowbarker merged commit 1ce518c into web-platform-tests:master May 23, 2015
@sideshowbarker
Copy link
Contributor

@annevk might want to review this (post-commit) & see servo/rust-url#108 for the context

@frewsxcv frewsxcv deleted the patch-1 branch May 23, 2015 15:09
@annevk
Copy link
Member

annevk commented May 25, 2015

These two tests make sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants