[sensors] Round off Ambient Light Sensor readouts to the nearest 50 Lux. #18501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 16, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1695412
branch
from
b749854
to
adccc9c
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1695412
branch
6 times, most recently
from
0581acc
to
48d2275
Compare
There have been some concerns regarding the precision of readouts from the Ambient Light Sensor. To decrease the entropy, we are rounding off the illuminance value to the nearest 50 Lux to mitigate the known attack vectors as summarized in [1]. Blink-specific sensor tests now use a ring buffer for readings needed for sensor/ambient-light-sensor.html Details: https://chromium-review.googlesource.com/c/chromium/src/+/1760954 [1] w3c/ambient-light#13 (comment) Bug: 642731, 606766 Change-Id: Icc4cfa6b87bd5a87c2cac6ebe322201d7dda6c33
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1695412
branch
from
48d2275
to
9b2dc35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been some concerns regarding the precision of readouts from the
Ambient Light Sensor. To decrease the entropy, we are rounding off the
illuminance value to the nearest 50 Lux to mitigate the known attack
vectors as summarized in [1].
Blink-specific sensor tests now use a ring buffer for readings needed for
sensor/ambient-light-sensor.html
Details: https://chromium-review.googlesource.com/c/chromium/src/+/1760954
[1] w3c/ambient-light#13 (comment)
Bug: 642731, 606766
Change-Id: Icc4cfa6b87bd5a87c2cac6ebe322201d7dda6c33
Reviewed-on: https://chromium-review.googlesource.com/1695412
WPT-Export-Revision: 884ffb94a50c596f5096886add184b33cad20d2d