autofocus: Change the timing of 'flush autofocus candidates' #19747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 17, 2019
3 tasks
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1863067
branch
from
d411527 to
fd5728c
Compare
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Oct 18, 2019
Now it runs before "run the resize steps". The previous timing could cause an issue that the auto-focused element didn't have up-to-date appearance even though "update the rendering" was done. Fixes #4992. Tests: web-platform-tests/wpt#19747
* ScriptedAnimationController kicks Document::FlushAutofocusCandidates Now ScriptedAnimationController takes into account of existence of autofocus candidates. * Document::FlushAutofocusCandidates needs to call UpdateStyleAndLayoutTree() for each of candidates. IsFocusable() needs up-to-date style. UpdateStyleAndLayoutTree() was unnecessary because FlushAutofocusCandidates() was called after layout. Bug: 1015275 Change-Id: I06dcb9b3cd2564d35fba3f893e7ce4b8736c91bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863067 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#707201}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1863067
branch
from
fd5728c to
e5113fb
Compare
|
The following three tests are flaky on Chrome (logs): Unstable results
Reproducible locally via: |
|
Author pinged via https://chromium-review.googlesource.com/c/chromium/src/+/1863067 |
|
The flakiness should be resolved when Chrome is updated to a version including r707201. |
|
@foolip @Hexcles Can we admin merge this, since the flakiness is (hopefully) fixed in Chromium already (but we're blocked on M79 upgrades due to https://crbug.com/1014629), and it isn't flaky on other browsers? |
|
Confirmed only wpt-chrome-dev-stability is failing in Taskcluster, admin merging now. |
zcorpan
pushed a commit
to whatwg/html
that referenced
this pull request
Nov 6, 2019
Now it runs before "run the resize steps". The previous timing could cause an issue that the auto-focused element didn't have up-to-date appearance even though "update the rendering" was done. Fixes #4992. Tests: web-platform-tests/wpt#19747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScriptedAnimationController kicks Document::FlushAutofocusCandidates
Now ScriptedAnimationController takes into account of existence of
autofocus candidates.
Document::FlushAutofocusCandidates needs to call
UpdateStyleAndLayoutTree() for each of candidates.
IsFocusable() needs up-to-date style. UpdateStyleAndLayoutTree() was
unnecessary because FlushAutofocusCandidates() was called after
layout.
Bug: 1015275
Change-Id: I06dcb9b3cd2564d35fba3f893e7ce4b8736c91bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863067
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707201}