Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SyntheticModules] Implements CSS Modules #20012

Merged
merged 1 commit into from
Dec 14, 2019

Commits on Dec 14, 2019

  1. [SyntheticModules] Implements CSS Modules

    This is the final change required for CSS Modules to be utilized by developers.
    Following the acceptance of this change, if you run chromium with the CSSModules runtime flag, the following is now valid syntax:
    
    <script type="module">
        import sheet from "./example.css";
    </script>
    
    CSS Modules Explainer:
    https://github.com/w3c/webcomponents/blob/gh-pages/proposals/css-modules-v1-explainer.md
    
    CSS Modules Spec PR:
    whatwg/html#4898
    
    Bug: 967018
    Change-Id: Ifdee5b92259fb7e4e9c8f9aa88e69a98eb55c551
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799923
    Commit-Queue: Sam Sebree <sasebree@microsoft.com>
    Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#724896}
    Sam Sebree authored and chromium-wpt-export-bot committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    4c31ae9 View commit details
    Browse the repository at this point in the history