Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadow dom: add test for text decoration #204

Merged
merged 3 commits into from
Jun 10, 2013
Merged

shadow dom: add test for text decoration #204

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55f0b2e
shadow dom: add test for text decoration
iseki-masaya Jun 8, 2013
43cb9a2
Modify reference html
iseki-masaya Jun 9, 2013
05335b2
Modify description
iseki-masaya Jun 10, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions shadow-dom/shadow-trees/text-decoration-001-ref.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Shadow DOM Test</title>
<link rel="author" title="Masaya Iseki" href="mailto:iseki.m.aa@gmail.com">
</head>
<body>
<span style="text-decoration: underline">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused. The text in the span will be underlined, won't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused too.
Reference html should not be underlined.
So I modify it.

if NOT underlined, it is success.
</span>
</body>
</html>
22 changes: 22 additions & 0 deletions shadow-dom/shadow-trees/text-decoration-001.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" >
<title>Text Decoration Under Line Test</title>
<link rel="reference" href="shadow-root-001-ref.html">
<link rel="author" title="Masaya Iseki" href="mailto:iseki.m.aa@gmail.com">
<link rel="help" href="https://www.w3.org/TR/shadow-dom/#text-decoration-property">
<meta name="assert" content="When shadow root has text-decoration, shadow tree is not affected.">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description, "When shadow root has text decoration, ...", seems wrong.

That should be a shadow host.

</head>
<body>
<span id="parent" style="text-decoration: underline">
</span>
<script>
var parent = document.getElementById('parent');
var shadow = parent.webkitCreateShadowRoot();
var child = document.createElement('span');
child.textContent = "if NOT underlined, it is success.";
shadow.appendChild(child);
</script>
</body>
</html>