Commits on Dec 31, 2019

1. Disallow recursive custom element constructions …

   With this CL, recursive custom element constructions are no
   longer allowed. I.e. this will now only run the constructor once:
     class extends HTMLElement {
       constructor() {
         super();
         customElements.upgrade(this);
       }
     }
   
   Previously, the code and spec had a bug which caused the above
   code snippet to infinitely recurse. In [1] the spec has changed,
   to set the custom element state to "failed" before the constructor
   is called. With this change in place, recursive calls will
   early-out at step #2 (of [2]), and avoid the recursion.
   
   [1] whatwg/html#5126
   [2] https://html.spec.whatwg.org/multipage/custom-elements.html#upgrades
   
   Bug: 966472
   Change-Id: I76e88c0b70132eee2482c304ef9e727ae1fe8fc7
   Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931644
   Reviewed-by: Kent Tamura <tkent@chromium.org>
   Commit-Queue: Mason Freed <masonfreed@chromium.org>
   Auto-Submit: Mason Freed <masonfreed@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#727841}

   

   mfreed7 authored and chromium-wpt-export-bot committed Dec 31, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for d0367e8
   • Browse repository at this point

   Copy the full SHA

   d0367e8 View commit details

   Browse the repository at this point in the history