DOM: document.origin is historical now #20995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
domenic
requested changes
Jan 2, 2020
annevk
force-pushed
the
annevk/document-origin
branch
from
bb38ff3 to
171e3dc
Compare
|
Okay... |
domenic
approved these changes
Jan 6, 2020
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Jan 6, 2020
Use self.origin instead. Tests: web-platform-tests/wpt#20995. Closes #410.
caiolima
pushed a commit
to caiolima/webkit
that referenced
this pull request
Jan 8, 2020
https://bugs.webkit.org/show_bug.cgi?id=205681 Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: Merge upstream changes from: - web-platform-tests/wpt#20995 * web-platform-tests/dom/historical-expected.txt: * web-platform-tests/dom/historical.html: * web-platform-tests/dom/nodes/Document-constructor-svg.svg: * web-platform-tests/dom/nodes/Document-constructor-xml.xml: * web-platform-tests/dom/nodes/Document-constructor.html: * web-platform-tests/dom/nodes/Node-cloneNode.html: * web-platform-tests/html/browsers/windows/browsing-context.html: * web-platform-tests/html/dom/usvstring-reflection.https.html: Source/WebCore: Remove document.origin, which was replaced by self.origin as per: - whatwg/dom#815 - whatwg/dom#410 Gecko has never supported this and Blink has already dropped support for it. No new tests, updated existing tests. * dom/Document.cpp: (WebCore::Document::origin const): Deleted. * dom/Document.h: * dom/Document.idl: * dom/ScriptExecutionContext.h: * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::printAccessDeniedMessage const): * workers/WorkerGlobalScope.h: * worklets/WorkletGlobalScope.cpp: (WebCore::WorkletGlobalScope::origin const): Deleted. * worklets/WorkletGlobalScope.h: Source/WebKitLegacy/mac: * DOM/DOMDocument.mm: (-[DOMDocument origin]): LayoutTests: * fast/dom/Document/document-constructor-expected.txt: * fast/dom/Document/document-constructor.html: * fast/dom/domparser-parsefromstring-origin-expected.txt: * fast/dom/domparser-parsefromstring-origin.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@254182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
https://bugs.webkit.org/show_bug.cgi?id=205681 Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: Merge upstream changes from: - web-platform-tests/wpt#20995 * web-platform-tests/dom/historical-expected.txt: * web-platform-tests/dom/historical.html: * web-platform-tests/dom/nodes/Document-constructor-svg.svg: * web-platform-tests/dom/nodes/Document-constructor-xml.xml: * web-platform-tests/dom/nodes/Document-constructor.html: * web-platform-tests/dom/nodes/Node-cloneNode.html: * web-platform-tests/html/browsers/windows/browsing-context.html: * web-platform-tests/html/dom/usvstring-reflection.https.html: Source/WebCore: Remove document.origin, which was replaced by self.origin as per: - whatwg/dom#815 - whatwg/dom#410 Gecko has never supported this and Blink has already dropped support for it. No new tests, updated existing tests. * dom/Document.cpp: (WebCore::Document::origin const): Deleted. * dom/Document.h: * dom/Document.idl: * dom/ScriptExecutionContext.h: * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::printAccessDeniedMessage const): * workers/WorkerGlobalScope.h: * worklets/WorkletGlobalScope.cpp: (WebCore::WorkletGlobalScope::origin const): Deleted. * worklets/WorkletGlobalScope.h: Source/WebKitLegacy/mac: * DOM/DOMDocument.mm: (-[DOMDocument origin]): LayoutTests: * fast/dom/Document/document-constructor-expected.txt: * fast/dom/Document/document-constructor.html: * fast/dom/domparser-parsefromstring-origin-expected.txt: * fast/dom/domparser-parsefromstring-origin.html: Canonical link: https://commits.webkit.org/219041@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/dom#815.