Add grouping tests #21

dzenana-trenutak · 2013-02-04T16:44:12Z

I started this batch before seeing prior/new contributions, and so hope very much that this round of tests does not step on anyone's toes. With these, though, perhaps this portion of the CR becomes fully covered. Please let me know if I missed anything, or any other ways I could/should improve this batch of tests.

Ms2ger · 2013-02-04T18:00:34Z

html/semantics/grouping-content/the-blockquote-element/grouping-blockquote.html

+        // check that "cite" is an "own" property
+        test(function () {	
+            assert_own_property(testElementProperties, "cite", strElement + " should have 'cite' as own property.");
+        }, strElement + " should have 'cite' as own property.");


This is not correct. Per WebIDL, "cite" should be a getter property of HTMLQuoteElement.prototype.

(Did you actually mean testElementProperties here, or did you mean testElement?)

Thank you, Ms2ger, for the catch! Does anything else need to be done to this batch, or was that it?

dzenana-trenutak · 2013-02-14T17:03:35Z

Sorry, can you specify which element still needs a test file? Thanks!

sideshowbarker · 2013-02-14T17:38:30Z

(Sorry I forgot to do the code thing). I meant the <main> element.

dzenana-trenutak · 2013-02-14T18:00:08Z

Ah! I'm writing tests for the 5.0 CR, not the 5.1 Nightly. Is that not what I should be doing?

sideshowbarker · 2013-02-14T18:12:33Z

Well, your PR is for the master branch, right? Which is for the dev (Nightly/5.1) version of the spec, not the CR version. I think in general the policy we're following is to write tests against the latest Nightly or WHATWG version, and we can subset them later for the CR branch as needed.

darobin · 2013-02-18T16:48:08Z

Actually @sideshowbarker , I think that it's perfectly fine this way. If @dzenana-trenutak were to include

tests into this PR, it would make it harder for me to cherry-pick the changes for the CR branch later. So it's better to keep it this way: 1) against master, and 2) without . We can add tests in a separate PR.

jgraham · 2013-03-25T12:58:31Z

http://critic.hoppipolla.co.uk/r/18

…uping Add grouping tests

When using pipes assume input is utf8 rather than assuming ascii

Bump Bootstrap static CSS files: 3.3.1 -> 3.3.5

Log tests that are disabled to make them easier to track.

Fix typo in docstring

chromedriver doesn't allow changing Object.prototype to add enumerable properties, but this test requires setting some values on Object.prototype. When Object.prototype.a is set to: {b: {c: 'on proto'}} chromedriver fails with: JavascriptErrorException: javascript error (500): Maximum call stack size exceeded (Session info: chrome=72.0.3626.121) Remote-end stacktrace: #0 0x563ff3a32a59 <unknown> #1 0x563ff39cb7f3 <unknown> #2 0x563ff38fcd7c <unknown> #3 0x563ff38ff78c <unknown> #4 0x563ff38ff5f7 <unknown> #5 0x563ff38ffbe7 <unknown> #6 0x563ff38fff1b <unknown> #7 0x563ff38a3f7a <unknown> #8 0x563ff3899bf2 <unknown> #9 0x563ff38a37b7 <unknown> #10 0x563ff3899ac3 <unknown> #11 0x563ff38782d2 <unknown> #12 0x563ff3879112 <unknown> #13 0x563ff39fe865 <unknown> #14 0x563ff39ff32b <unknown> #15 0x563ff39ff70c <unknown> #16 0x563ff39d940a <unknown> #17 0x563ff39ff997 <unknown> #18 0x563ff39e9947 <unknown> #19 0x563ff3a1a800 <unknown> #20 0x563ff3a3c8be <unknown> #21 0x7f3bf4545494 start_thread #22 0x7f3bf2d58a8f clone Ran 1 tests finished in 2.0 seconds. • 0 ran as expected. 0 tests skipped. • 1 tests had errors unexpectedly Work around this problem by cleaning up the test environment so Object.prototype no longer has the override by the time chromedriver tries to inspect the test result. While here, fix the other tests to use the t.add_cleanup() function so they'll cleanup their test environment in case they exit in some other way besides reaching t.done(). The underlying chromedriver issue is tracked upstream at https://crbug.com/chromedriver/2555. Bug: 934844 Change-Id: Id1b4ab2a908bfbc001e2a2d045eeec3ef01c24d9

1b88d78a38 Release 1.0.2. a2602c812c Fix #21: setup_requires setuptools 17.1 3b0a393c27 Release 1.0.1. 6848ca897c Fixes #18: depend on ordereddict on old Pythons d967e51973 Version bump to 1.0.0. 9610297407 Merge pull request #17 from rbtcollins/mfield-varargs_class_method f2c0368f2e Deal with unbound methods like foo(*args). 3306968f41 Cleanup tests: e70929ceb2 Update README.rst fa0f64c06a Use the ordereddict pypi package when needed 7693e97193 Add .gitignore e7fb456d52 Merge pull request #6 from rbtcollins/github 43ee6b7b4e Fixup tox patch. 4e80d81554 Add tox.ini for tox 95ce8ebc49 README.rst: A few more tweaks 6cea81cced README.rst: Add detail to example d131c4af91 README.rst: compatability => compatibility 82d9c949d6 Avoid easy-install in travis. aa7288e532 Updates to fit into the new home. 32a9d3e37b Closes #14: Fix binding with self as a kwarg. git-subtree-dir: tools/third_party/funcsigs git-subtree-split: 29e7a6ebb21bf1c4dc9aca710d9fbfea08875849

…db3d29db4 9db3d29db4 Bump version number to reflect functional changes (#25) c6aea56f8b Stop wrapping os.popen3 (#24) 353b4aaf8a Give up expecting echo_client to be unicode safe (#23) 9ae2b3c90b Make tests work with python 2 on Windows (#20) e894c1b2ad Update the URL in setup.py (#19) f76e23c094 Fix incorrect use of "is" for integer comparison (#21) 3ab411d97f Fix version comparisons (#22) git-subtree-dir: tools/third_party/pywebsocket3 git-subtree-split: 9db3d29db4f3e3efb1722c0210bc88500ab00611

This reverts commit 3438f2a59daa31ad1d86777d73e1cff836cef570. Reason for revert: Suspect causing blink_wpt_tests and blink_web_tests faliure on Linux Tests (dbg)(1) bot. Failed tests: blink_wpt_tests failed because of: external/wpt/css/css-contain/content-visibility/detach-locked-slot-children-crash.html external/wpt/css/css-contain/content-visibility/element-reassigned-to-skipped-slot.html external/wpt/css/css-contain/content-visibility/element-reassigned-to-slot-in-skipped-subtree.html external/wpt/html/semantics/forms/the-input-element/focus-dynamic-type-change-on-blur.html ...7 more failure(s) (11 total)... blink_web_tests failed because of: accessibility/details-summary-crash.html fast/events/drag-on-removed-slider-does-not-crash.html fast/forms/range/range-type-change-onchange-2.html html/details_summary/details-add-summary.html ...5 more failure(s) (9 total)... First build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/114032/overview Sample log: --- STDERR: #6 0x7fc01bd0361d logging::CheckError::~CheckError() STDERR: #7 0x7fbffd21d08a blink::FlatTreeTraversal::AssertPrecondition() STDERR: #8 0x7fbffd21cfd5 blink::FlatTreeTraversal::Parent() STDERR: #9 0x7fbffd3c2a45 blink::FlatTreeTraversal::AncestorsOf() STDERR: #10 0x7fbffd3d410e blink::(anonymous namespace)::NearestLockedExclusiveAncestor() STDERR: #11 0x7fbffd3d3d17 blink::DisplayLockUtilities::IsInUnlockedOrActivatableSubtree() STDERR: #12 0x7fbfedfabc4b blink::DisplayLockUtilities::ShouldIgnoreNodeDueToDisplayLock() STDERR: #13 0x7fbfedf8b61c blink::AXObject::ToString() STDERR: #14 0x7fbfedf8eccc blink::AXObject::Detach() STDERR: #15 0x7fbfedf512df blink::AXNodeObject::Detach() STDERR: #16 0x7fbfedf2d6a5 blink::AXLayoutObject::Detach() STDERR: #17 0x7fbfedfce51a blink::AXObjectCacheImpl::Remove() STDERR: #18 0x7fbfedfcd998 blink::AXObjectCacheImpl::Remove() STDERR: #19 0x7fbfedfcdd74 blink::AXObjectCacheImpl::Remove() STDERR: #20 0x7fbfedfce992 blink::AXObjectCacheImpl::Remove() STDERR: #21 0x7fbffe6d16be blink::LayoutObject::WillBeDestroyed() --- Original change's description: > [A11y] Reland targeted cached property invalidation > > Relands the following CLS: > * Enhance performance by targeting value updates to specific nodes, commit 704633e6846e44b20c488a3eb98fa43c2c8e4591. > * Don't queue anything for irrelevant attribute changes, commit 2c66a62ed62e601b7a81271e4be4f9e173ce9afc. > * Add comment explaining call to UpdateStyleAndLayoutTreeForNode(), commit 73b9eed3b48bc8ce70de657672755f44a89e7358. > * Ensure cached values not invalidated during the computation of them, commit 4d167a62cd13d5209ecefb664e3690ac955bc559. > * Run a test with --force-renderer-accessibility that used to fail, commit cab7ecd829b24acf677e02f8f118085eaad7f799. > * Simplify code to update cached focusable state, commit 79cb184e5dab5f6084ec78d485bd9496eaa0aaf8. > * Simplify code that invalidates cached values on an AXObject, commit 6df79a50a55fe5cf99d2c50f7308e1236361b771. > > Fixed: 1446864, 1446550, 1434555, 1362758 > Change-Id: I16855bdcb746cb41387b69e1e97ab72ffc47e342 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4545510 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Jacques Newman <janewman@microsoft.com> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1157878} Change-Id: Iefe59fe1933747346eda8827fd683f310d6cddb3 No-Presubmit: true No-Tree-Checks: true No-Try: true

This reverts commit 3438f2a59daa31ad1d86777d73e1cff836cef570. Reason for revert: Suspect causing blink_wpt_tests and blink_web_tests failure on Linux Tests (dbg)(1) bot. Failed tests: blink_wpt_tests failed because of: external/wpt/css/css-contain/content-visibility/detach-locked-slot-children-crash.html external/wpt/css/css-contain/content-visibility/element-reassigned-to-skipped-slot.html external/wpt/css/css-contain/content-visibility/element-reassigned-to-slot-in-skipped-subtree.html external/wpt/html/semantics/forms/the-input-element/focus-dynamic-type-change-on-blur.html ...7 more failure(s) (11 total)... blink_web_tests failed because of: accessibility/details-summary-crash.html fast/events/drag-on-removed-slider-does-not-crash.html fast/forms/range/range-type-change-onchange-2.html html/details_summary/details-add-summary.html ...5 more failure(s) (9 total)... First build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/114032/overview Sample log: --- STDERR: #6 0x7fc01bd0361d logging::CheckError::~CheckError() STDERR: #7 0x7fbffd21d08a blink::FlatTreeTraversal::AssertPrecondition() STDERR: #8 0x7fbffd21cfd5 blink::FlatTreeTraversal::Parent() STDERR: #9 0x7fbffd3c2a45 blink::FlatTreeTraversal::AncestorsOf() STDERR: #10 0x7fbffd3d410e blink::(anonymous namespace)::NearestLockedExclusiveAncestor() STDERR: #11 0x7fbffd3d3d17 blink::DisplayLockUtilities::IsInUnlockedOrActivatableSubtree() STDERR: #12 0x7fbfedfabc4b blink::DisplayLockUtilities::ShouldIgnoreNodeDueToDisplayLock() STDERR: #13 0x7fbfedf8b61c blink::AXObject::ToString() STDERR: #14 0x7fbfedf8eccc blink::AXObject::Detach() STDERR: #15 0x7fbfedf512df blink::AXNodeObject::Detach() STDERR: #16 0x7fbfedf2d6a5 blink::AXLayoutObject::Detach() STDERR: #17 0x7fbfedfce51a blink::AXObjectCacheImpl::Remove() STDERR: #18 0x7fbfedfcd998 blink::AXObjectCacheImpl::Remove() STDERR: #19 0x7fbfedfcdd74 blink::AXObjectCacheImpl::Remove() STDERR: #20 0x7fbfedfce992 blink::AXObjectCacheImpl::Remove() STDERR: #21 0x7fbffe6d16be blink::LayoutObject::WillBeDestroyed() --- Original change's description: > [A11y] Reland targeted cached property invalidation > > Relands the following CLS: > * Enhance performance by targeting value updates to specific nodes, commit 704633e6846e44b20c488a3eb98fa43c2c8e4591. > * Don't queue anything for irrelevant attribute changes, commit 2c66a62ed62e601b7a81271e4be4f9e173ce9afc. > * Add comment explaining call to UpdateStyleAndLayoutTreeForNode(), commit 73b9eed3b48bc8ce70de657672755f44a89e7358. > * Ensure cached values not invalidated during the computation of them, commit 4d167a62cd13d5209ecefb664e3690ac955bc559. > * Run a test with --force-renderer-accessibility that used to fail, commit cab7ecd829b24acf677e02f8f118085eaad7f799. > * Simplify code to update cached focusable state, commit 79cb184e5dab5f6084ec78d485bd9496eaa0aaf8. > * Simplify code that invalidates cached values on an AXObject, commit 6df79a50a55fe5cf99d2c50f7308e1236361b771. > > Fixed: 1446864, 1446550, 1434555, 1362758 > Change-Id: I16855bdcb746cb41387b69e1e97ab72ffc47e342 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4545510 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Jacques Newman <janewman@microsoft.com> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1157878} Change-Id: Iefe59fe1933747346eda8827fd683f310d6cddb3 No-Presubmit: true No-Tree-Checks: true No-Try: true

This reverts commit 3438f2a59daa31ad1d86777d73e1cff836cef570. Reason for revert: Suspect causing blink_wpt_tests and blink_web_tests failure on Linux Tests (dbg)(1) bot. Failed tests: blink_wpt_tests failed because of: external/wpt/css/css-contain/content-visibility/detach-locked-slot-children-crash.html external/wpt/css/css-contain/content-visibility/element-reassigned-to-skipped-slot.html external/wpt/css/css-contain/content-visibility/element-reassigned-to-slot-in-skipped-subtree.html external/wpt/html/semantics/forms/the-input-element/focus-dynamic-type-change-on-blur.html ...7 more failure(s) (11 total)... blink_web_tests failed because of: accessibility/details-summary-crash.html fast/events/drag-on-removed-slider-does-not-crash.html fast/forms/range/range-type-change-onchange-2.html html/details_summary/details-add-summary.html ...5 more failure(s) (9 total)... First build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/114032/overview Sample log: --- STDERR: #6 0x7fc01bd0361d logging::CheckError::~CheckError() STDERR: #7 0x7fbffd21d08a blink::FlatTreeTraversal::AssertPrecondition() STDERR: #8 0x7fbffd21cfd5 blink::FlatTreeTraversal::Parent() STDERR: #9 0x7fbffd3c2a45 blink::FlatTreeTraversal::AncestorsOf() STDERR: #10 0x7fbffd3d410e blink::(anonymous namespace)::NearestLockedExclusiveAncestor() STDERR: #11 0x7fbffd3d3d17 blink::DisplayLockUtilities::IsInUnlockedOrActivatableSubtree() STDERR: #12 0x7fbfedfabc4b blink::DisplayLockUtilities::ShouldIgnoreNodeDueToDisplayLock() STDERR: #13 0x7fbfedf8b61c blink::AXObject::ToString() STDERR: #14 0x7fbfedf8eccc blink::AXObject::Detach() STDERR: #15 0x7fbfedf512df blink::AXNodeObject::Detach() STDERR: #16 0x7fbfedf2d6a5 blink::AXLayoutObject::Detach() STDERR: #17 0x7fbfedfce51a blink::AXObjectCacheImpl::Remove() STDERR: #18 0x7fbfedfcd998 blink::AXObjectCacheImpl::Remove() STDERR: #19 0x7fbfedfcdd74 blink::AXObjectCacheImpl::Remove() STDERR: #20 0x7fbfedfce992 blink::AXObjectCacheImpl::Remove() STDERR: #21 0x7fbffe6d16be blink::LayoutObject::WillBeDestroyed() --- Original change's description: > [A11y] Reland targeted cached property invalidation > > Relands the following CLS: > * Enhance performance by targeting value updates to specific nodes, commit 704633e6846e44b20c488a3eb98fa43c2c8e4591. > * Don't queue anything for irrelevant attribute changes, commit 2c66a62ed62e601b7a81271e4be4f9e173ce9afc. > * Add comment explaining call to UpdateStyleAndLayoutTreeForNode(), commit 73b9eed3b48bc8ce70de657672755f44a89e7358. > * Ensure cached values not invalidated during the computation of them, commit 4d167a62cd13d5209ecefb664e3690ac955bc559. > * Run a test with --force-renderer-accessibility that used to fail, commit cab7ecd829b24acf677e02f8f118085eaad7f799. > * Simplify code to update cached focusable state, commit 79cb184e5dab5f6084ec78d485bd9496eaa0aaf8. > * Simplify code that invalidates cached values on an AXObject, commit 6df79a50a55fe5cf99d2c50f7308e1236361b771. > > Fixed: 1446864, 1446550, 1434555, 1362758 > Change-Id: I16855bdcb746cb41387b69e1e97ab72ffc47e342 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4545510 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Jacques Newman <janewman@microsoft.com> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1157878} Change-Id: Iefe59fe1933747346eda8827fd683f310d6cddb3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615927 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Owners-Override: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takashi Sakamoto <tasak@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1157993}

Ms2ger reviewed Feb 4, 2013
View reviewed changes

Fix blockquote tests

9f4bb4c

Thank you, Ms2ger, for the catch! Does anything else need to be done to this batch, or was that it?

sideshowbarker closed this Mar 1, 2013

sideshowbarker reopened this Mar 1, 2013

jgraham closed this Mar 25, 2013

jgraham reopened this Mar 25, 2013

sideshowbarker added a commit that referenced this pull request Apr 13, 2013

Merge pull request #21 from dzenana-trenutak/submission/dzenana.t-gro…

4990e54

…uping Add grouping tests

sideshowbarker merged commit 4990e54 into web-platform-tests:master Apr 13, 2013

jgraham pushed a commit that referenced this pull request Apr 13, 2017

Merge pull request #21 from w3c/jgraham/sub_encoding

7e74997

When using pipes assume input is utf8 rather than assuming ascii

jgraham added a commit that referenced this pull request Apr 13, 2017

Merge pull request #21 from frewsxcv/bump-bootstrap

8cadcc6

Bump Bootstrap static CSS files: 3.3.1 -> 3.3.5

jgraham added a commit that referenced this pull request Apr 21, 2017

Merge pull request #21 from w3c/jgraham/log_disabled

caa112d

Log tests that are disabled to make them easier to track.

AutomatedTester referenced this pull request in AutomatedTester/web-platform-tests Dec 1, 2017

Merge pull request #21 from wbolster/patch-1

9b34af2

Fix typo in docstring

jaquettac86 referenced this pull request Oct 17, 2020

Relocate to link relationship to HTML spec (#24447)

a337b18

WeizhongX mentioned this pull request Feb 23, 2021

WebDriverException exception is not properly captured #27751

Closed

chromium-wpt-export-bot mentioned this pull request Jun 15, 2023

Revert "[A11y] Reland targeted cached property invalidation" #40564

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add grouping tests #21

Add grouping tests #21

dzenana-trenutak commented Feb 4, 2013

Ms2ger Feb 4, 2013

dzenana-trenutak commented Feb 14, 2013

sideshowbarker commented Feb 14, 2013

dzenana-trenutak commented Feb 14, 2013

sideshowbarker commented Feb 14, 2013

darobin commented Feb 18, 2013

jgraham commented Mar 25, 2013

Add grouping tests #21

Add grouping tests #21

Conversation

dzenana-trenutak commented Feb 4, 2013

Ms2ger Feb 4, 2013

Choose a reason for hiding this comment

dzenana-trenutak commented Feb 14, 2013

sideshowbarker commented Feb 14, 2013

dzenana-trenutak commented Feb 14, 2013

sideshowbarker commented Feb 14, 2013

darobin commented Feb 18, 2013

jgraham commented Mar 25, 2013