-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort the registrations returned by getRegistrations() by registration ID. #21046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
f7a51e3
to
0dfca6c
Compare
… ID. This patch makes the order of the registrations returned by getRegistrations() be sorted by registration ID, which fixes the flaky test of getregistrations.https.html. Related Github issue is in w3c/ServiceWorker#1465 Bug: 925740 Change-Id: Iaa5716eec886232df61bd23487fbae5c63413e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984900 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Wei4 Wang <wei4.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#732749}
0dfca6c
to
c55e489
Compare
Failed the stability check on chrome-dev:
Unable to reproduce locally however, so let's try re-running. |
Failed again, and I was able to reproduce locally now as well. Will open a Chromium bug, but cc @makotoshimazu as an FYI |
Filed https://bugs.chromium.org/p/chromium/issues/detail?id=1043645, admin-merging this. |
This patch makes the order of the registrations returned by
getRegistrations() be sorted by registration ID, which fixes the flaky
test of getregistrations.https.html. Related Github issue is in
w3c/ServiceWorker#1465
Bug: 925740
Change-Id: Iaa5716eec886232df61bd23487fbae5c63413e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984900
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Wei4 Wang <wei4.wang@intel.com>
Cr-Commit-Position: refs/heads/master@{#732749}