Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the registrations returned by getRegistrations() by registration ID. #21046

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 6, 2020

This patch makes the order of the registrations returned by
getRegistrations() be sorted by registration ID, which fixes the flaky
test of getregistrations.https.html. Related Github issue is in
w3c/ServiceWorker#1465

Bug: 925740
Change-Id: Iaa5716eec886232df61bd23487fbae5c63413e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984900
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Wei4 Wang <wei4.wang@intel.com>
Cr-Commit-Position: refs/heads/master@{#732749}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1984900 branch 2 times, most recently from f7a51e3 to 0dfca6c Compare January 16, 2020 10:26
… ID.

This patch makes the order of the registrations returned by
getRegistrations() be sorted by registration ID, which fixes the flaky
test of getregistrations.https.html. Related Github issue is in
w3c/ServiceWorker#1465

Bug: 925740
Change-Id: Iaa5716eec886232df61bd23487fbae5c63413e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984900
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Wei4 Wang <wei4.wang@intel.com>
Cr-Commit-Position: refs/heads/master@{#732749}
@stephenmcgruer
Copy link
Contributor

Failed the stability check on chrome-dev:

 0:26.96 INFO |                              Test                             |                     Subtest                     |          Results           |                                                                                                                                                                                                                        Messages                                                                                                                                                                                                                       |
 0:26.96 INFO |---------------------------------------------------------------|-------------------------------------------------|----------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 0:26.96 INFO | `/service-workers/service-worker/getregistrations.https.html` | `Register multiple times then getRegistrations` | **FAIL: 1/10, PASS: 9/10** | `assert_array_equals: expected property 0 to be object "[object ServiceWorkerRegistration]" but got object "[object ServiceWorkerRegistration]" (expected array [object "[object ServiceWorkerRegistration]", object "[object ServiceWorkerRegistration]", object "[object ServiceWorkerRegistration]"] got [object "[object ServiceWorkerRegistration]", object "[object ServiceWorkerRegistration]", object "[object ServiceWorkerRegistration]"])` |
 0:26.96 INFO 

Unable to reproduce locally however, so let's try re-running.

@stephenmcgruer
Copy link
Contributor

Failed again, and I was able to reproduce locally now as well. Will open a Chromium bug, but cc @makotoshimazu as an FYI

@stephenmcgruer
Copy link
Contributor

Filed https://bugs.chromium.org/p/chromium/issues/detail?id=1043645, admin-merging this.

@stephenmcgruer stephenmcgruer merged commit 3b8990e into master Jan 20, 2020
@stephenmcgruer stephenmcgruer deleted the chromium-export-cl-1984900 branch January 20, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants