[Azure Pipelines] Consistently use the "Use Python Version" task #21722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
commented
Feb 11, 2020
.azure-pipelines.yml
Outdated
| @@ -229,9 +247,6 @@ jobs: | |||
| - task: UsePythonVersion@0 | |||
| inputs: | |||
| versionSpec: '3.6.x' | |||
| - task: UsePythonVersion@0 | |||
There was a problem hiding this comment.
I've asked about this in https://github.com/web-platform-tests/wpt/pull/20725/files#r377569491. It caused the job to start failing, so I'll probably revert and deal with it separately.
jgraham
reviewed
Feb 11, 2020
wpt-pr-bot
requested review from
Hexcles,
jugglinmike,
KyleJu,
LukeZielinski and
stephenmcgruer
|
Waiting for CI to with all tests running before reverting and squashing into a single commit. |
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/tool/use-python-version?view=azure-devops The default python/pip on the macOS VMs don't any longer. It may be possible to fix this, but to fix the urgent issue use the method that's supported by Azure Pipelines. The python version will remain unchanged at 2.7.17, but pip will change from 19.3.1 to 20.0.2. pip_install.yml can be simplified because the remaining code path is the same for macOS and Windows. Fixes #21691.
foolip
force-pushed
the
foolip/azure-macOS-UsePythonVersion
branch
from
f4d3d00
to
76a93df
Compare
jgraham
approved these changes
Feb 11, 2020
Don't what? (Work?). What I'm not understanding from this change is why we ever had anything that wasn't the default Azure Pipelines task for installing Python+pip. |
|
Yes, they don't work. I'll fix the commit message. Before we just used the python+pip that's installed on macOS, and now we'll be using one that Azure Pipelines can install, or rather it's there in a tools directory and some paths are updated by the "Use Python Version" task. |
foolip
added a commit
that referenced
this pull request
May 20, 2020
Since #21722 we don't use the default macOS Python version. The problem is likely gone.
foolip
added a commit
that referenced
this pull request
May 25, 2020
Since #21722 we don't use the default macOS Python version. The problem is likely gone.
stephenmcgruer
pushed a commit
that referenced
this pull request
May 25, 2020
Since #21722 we don't use the default macOS Python version. The problem is likely gone.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 27, 2020
…'*' on macOS, a=testonly Automatic update from web-platform-tests [Azure Pipelines] stop setting no_proxy='*' on macOS (#23709) Since web-platform-tests/wpt#21722 we don't use the default macOS Python version. The problem is likely gone. -- wpt-commits: ab9402eb6a8e4ec5a7009a5d8d994a37615785a7 wpt-pr: 23709
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
May 27, 2020
…'*' on macOS, a=testonly Automatic update from web-platform-tests [Azure Pipelines] stop setting no_proxy='*' on macOS (#23709) Since web-platform-tests/wpt#21722 we don't use the default macOS Python version. The problem is likely gone. -- wpt-commits: ab9402eb6a8e4ec5a7009a5d8d994a37615785a7 wpt-pr: 23709
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/tool/use-python-version?view=azure-devops
The default python/pip on the macOS VMs don't any longer. It may be
possible to fix this, but to fix the urgent issue use the method
that's supported by Azure Pipelines.
The python version will remain unchanged at 2.7.17, but pip will
change from 19.3.1 to 20.0.2.
pip_install.yml can be simplified because the remaining code path is
the same for macOS and Windows.
Fixes #21691.