Fix idlharness.js' handling of Float(32/64)Array types #23323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 29, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2172163
branch
2 times, most recently
from
da99c52
to
6b0aa23
Compare
idlharness.js does not seem to correctly handle Float32Array and
Float64Array types. When an interface uses such types, the tests will
fail with the exception thrown from idlharness.js:1221:
`throw new IdlHarnessError("Unrecognized type " + type);`
The fix is to teach idlharness.js how to handle Float(32/64)Array types,
and, while at it, to teach it to handle other typed arrays.
Bug: 1074548
Change-Id: I549f6ae1ea13590207bd4f49b94439ad2a43a13d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172163
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#764058}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2172163
branch
from
6b0aa23
to
0f39ee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idlharness.js does not seem to correctly handle Float32Array and
Float64Array types. When an interface uses such types, the tests will
fail with the exception thrown from idlharness.js:1221:
throw new IdlHarnessError("Unrecognized type " + type);The fix is to teach idlharness.js how to handle Float(32/64)Array types,
and, while at it, to teach it to handle other typed arrays.
Bug: 1074548
Change-Id: I549f6ae1ea13590207bd4f49b94439ad2a43a13d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172163
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#764058}