Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generated tests due to upstream html5lib changes #24059

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Update generated tests due to upstream html5lib changes #24059

merged 1 commit into from
Jun 9, 2020

Conversation

stephenmcgruer
Copy link
Contributor

It turns out that html/tools/build.sh clones html5lib-python directly at
HEAD, and uses that to generate tests. Upstream recently updated with
some new behavior, which then changes the generated tests; bring them
into WPT to stop the 'update-build-scripts' check from failing on
unrelated PRs.

@stephenmcgruer
Update generated tests due to upstream html5lib changes
4a4eeb7 
It turns out that html/tools/build.sh clones html5lib-python directly at
HEAD, and uses that to generate tests. Upstream recently updated with
some new behavior, which then changes the generated tests; bring them
into WPT to stop the 'update-build-scripts' check from failing on
unrelated PRs.
@wpt-pr-bot wpt-pr-bot added the html label Jun 9, 2020
Ms2ger
Ms2ger approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at it, but the CI should not remain broken. Can you update html/tools/build.sh to pin the commit until we move the source data into wpt?

@Ms2ger Ms2ger merged commit cf7f8ae into master Jun 9, 2020
@Ms2ger Ms2ger deleted the smcgruer/update-html branch June 9, 2020 14:22
@gsnedders
Copy link
Member

FWIW, given @stephenmcgruer pinged @annevk on IRC about this:

@stephenmcgruer
Copy link
Contributor Author

Can you update html/tools/build.sh to pin the commit until we move the source data into wpt?

I think this is a very good idea, but I want to check with @gsnedders - are you expecting to vendor html5lib soon? At which point I believe you mentioned you were going to switch html/tools/build.sh to use the vendored version. (Or maybe I have this all wrong :D)

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 12, 2020

Can you update html/tools/build.sh to pin the commit until we move the source data into wpt?

I think this is a very good idea, but I want to check with @gsnedders - are you expecting to vendor html5lib soon? At which point I believe you mentioned you were going to switch html/tools/build.sh to use the vendored version. (Or maybe I have this all wrong :D)

I'm guessing that pinning the commit should take no more than an hour; I expect the merge will take a little longer.

stephenmcgruer added a commit that referenced this pull request Jun 12, 2020
@stephenmcgruer
Pin version of html5lib used in html/tools/build.sh
6f0a357 
See #24059 (review)
@stephenmcgruer stephenmcgruer mentioned this pull request Jun 12, 2020
Merged
@stephenmcgruer
Copy link
Contributor Author

I'm guessing that pinning the commit should take no more than an hour; I expect the merge will take a little longer.

How reasonable; #24131

@gsnedders
Copy link
Member

At which point I believe you mentioned you were going to switch html/tools/build.sh to use the vendored version. (Or maybe I have this all wrong :D)

No, the plan is to migrate the source files into wpt; see html5lib/html5lib-tests#127.

stephenmcgruer added a commit that referenced this pull request Jun 12, 2020
@stephenmcgruer
Pin version of html5lib used in html/tools/build.sh (#24131)
0614cc3 
See #24059 (review)
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 17, 2020
@stephenmcgruer @moz-wptsync-bot
Bug 1645417 [wpt PR 24131] - Pin version of html5lib used in html/too…
b5e9d94 
…ls/build.sh, a=testonly

Automatic update from web-platform-tests
Pin version of html5lib used in html/tools/build.sh (#24131)

See web-platform-tests/wpt#24059 (review)
--

wpt-commits: 0614cc3f735509e57e29fdc482e67565601bf12e
wpt-pr: 24131
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Jun 18, 2020
@stephenmcgruer @moz-wptsync-bot
Bug 1645417 [wpt PR 24131] - Pin version of html5lib used in html/too…
a71f87c 
…ls/build.sh, a=testonly

Automatic update from web-platform-tests
Pin version of html5lib used in html/tools/build.sh (#24131)

See web-platform-tests/wpt#24059 (review)
--

wpt-commits: 0614cc3f735509e57e29fdc482e67565601bf12e
wpt-pr: 24131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

@annevk annevk Awaiting requested review from annevk

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zcorpan zcorpan Awaiting requested review from zcorpan

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@annevk annevk

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephenmcgruer @gsnedders @Ms2ger @annevk @wpt-pr-bot