Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streams: fix IDL tests #24267

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Streams: fix IDL tests #24267

merged 3 commits into from
Jun 23, 2020

Conversation

MattiasBuelens
Copy link
Contributor

The new IDL harness tests for Streams (#22982) did not correctly instantiate all tested interfaces. This PR fixes them.

@MattiasBuelens MattiasBuelens mentioned this pull request Jun 21, 2020
Closed
ricea
ricea reviewed Jun 22, 2020
View reviewed changes
Copy link
Contributor

@ricea ricea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

streams/idlharness.any.js Outdated Show resolved Hide resolved
ricea
ricea approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@ricea ricea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MattiasBuelens MattiasBuelens mentioned this pull request Jun 22, 2020
Merged
@MattiasBuelens
Copy link
Contributor Author

Dangit, a linter error. I'm on it. 👷

I also opened yet another PR to get ReadableStreamBYOBRequest.view to type-check correctly: #24298

@MattiasBuelens
Copy link
Contributor Author

Huh, it doesn't look like there's actually a linter error, but rather a problem with the task itself:

INFO: Downloading https://community-tc.services.mozilla.com/api/queue/v1/task/MCDyAHzrSzC4ab5eZ50trA Try 1/5
git rev-parse task_head
git ls-remote origin refs/pull/24267/head
CRITICAL: task_head points at 61e032472d1f34b69ff03a396e243bae34d4db1a, expected None. This may be because the branch was updated
[taskcluster 2020-06-22 19:24:09.150Z] === Task Finished ===
[taskcluster 2020-06-22 19:24:09.234Z] Unsuccessful task run with exit code: 1 completed in 32.431 seconds

Perhaps this is caused by the on-going GitHub incident? For me, I was temporarily unable to access github.com, maybe the CI encountered a similar problem.

I'd suggest we re-run this once GitHub has calmed down a bit. 😅

@domenic domenic closed this Jun 23, 2020
@domenic domenic reopened this Jun 23, 2020
@domenic domenic merged commit e32f3a1 into web-platform-tests:master Jun 23, 2020
@MattiasBuelens MattiasBuelens deleted the streams-fix-idl-tests branch October 12, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricea ricea ricea approved these changes

@domenic domenic Awaiting requested review from domenic

@wanderview wanderview Awaiting requested review from wanderview

@youennf youennf Awaiting requested review from youennf

@yutakahirano yutakahirano Awaiting requested review from yutakahirano

Assignees

@ricea ricea

Labels
streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MattiasBuelens @ricea @domenic @wpt-pr-bot