Update math-level depth to match the new syntax #25694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussed with the CSSWG at [1]. Syntax changes are - Split scriptlevel(...) into math-depth: ... and font-size: math. - Rename auto to auto-add The old tests math-script-level-001 and math-script-level-003 are restored and adjusted to check the computed math-level in various situations and that the math-level does not have any effect when the specified font-size is not 'math'. [1] w3c/csswg-drafts#5389
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Sep 25, 2020
Experimental font-size: scriptlevel(...) syntax was implemented in [1]. This CL updates it to match what was agreed with the CSSWG [2] as well as new WPT tests [3]: - Split scriptlevel(...) into math-depth: ... and font-size: math. - Rename auto to auto-add This CL also updates the MathML UA stylesheet to use the new syntax. To compute font-size, one need the inherited math-style and the inherited/computed math-depth. So math-style does not need to be High priority. Additionally Blink computes the High priority alphabetically, so math-depth must be handled specially. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2184131 [2] w3c/csswg-drafts#5389 [3] web-platform-tests/wpt#25694 Bug: 6606, 1023292 Change-Id: I8a5bf245fa6158633261ed167800fc5feb0c3564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423843 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#810610}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Experimental font-size: scriptlevel(...) syntax was implemented in [1]. This CL updates it to match what was agreed with the CSSWG [2] as well as new WPT tests [3]: - Split scriptlevel(...) into math-depth: ... and font-size: math. - Rename auto to auto-add This CL also updates the MathML UA stylesheet to use the new syntax. To compute font-size, one need the inherited math-style and the inherited/computed math-depth. So math-style does not need to be High priority. Additionally Blink computes the High priority alphabetically, so math-depth must be handled specially. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2184131 [2] w3c/csswg-drafts#5389 [3] web-platform-tests/wpt#25694 Bug: 6606, 1023292 Change-Id: I8a5bf245fa6158633261ed167800fc5feb0c3564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423843 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#810610} GitOrigin-RevId: 0feb1d195c8a413c53e808ed95df7e1b78089703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed with the CSSWG at [1]. Syntax changes are
The old tests math-script-level-001 and math-script-level-003
are restored and adjusted to check the computed math-level in
various situations and that the math-level does not have any
effect when the specified font-size is not 'math'.
[1] w3c/csswg-drafts#5389