Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test newline normalization in form-associated custom elements. #26838

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Test newline normalization in form-associated custom elements. #26838

merged 3 commits into from
Dec 14, 2020

Conversation

andreubotella
Copy link
Member

No description provided.

@domenic
Copy link
Member

domenic commented Dec 10, 2020

@tkent-google will probably be the best person to review this, but from what I gather in IRC, you are working on a large project surrounding form data serialization and newlines, and so probably it'd be best to wait on reviews until that's settled and you have a writeup somewhere explaining the desired behavior?

@andreubotella
Copy link
Member Author

andreubotella commented Dec 10, 2020

Although I ran into this as part of working on whatwg/url#562, these tests (other than the ones that deal with filenames) reflect the spec-mandated behavior: setting a string or a File as a FACE's value should cause the entry construction algorithm to invoke append an entry, which newline-normalizes names and string values; but setting a FormData should cause the entry construction algorithm to append the FormData's entries without normalization.

Since the parts dealing with File objects will probably change, I should probably split them into a .tentative file.

@domenic domenic assigned tkent-google and unassigned hayatoito Dec 10, 2020
@domenic
Copy link
Member

domenic commented Dec 10, 2020

In that case it's probably fine to review and merge as-is. That will make any future reviews for changes related to File objects simpler.

I will assign @tkent-google then, but @tkent-google feel free to say you would rather have someone else review; I realize you did not sign up to review this directory in general.

@andreubotella
Copy link
Member Author

So the (bare) "filename" tests don't agree with the spec as it is right now, but would agree with any change to the spec that would fix whatwg/url#562. But the "FormData filename" tests might depend on the specifics of that fix. So on second thought, it'd be best to remove those or make them tentative for now.

@tkent-google tkent-google merged commit 24ecd21 into web-platform-tests:master Dec 14, 2020
@andreubotella andreubotella deleted the newlines-in-face branch December 14, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants