-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test newline normalization in form-associated custom elements. #26838
Test newline normalization in form-associated custom elements. #26838
Conversation
@tkent-google will probably be the best person to review this, but from what I gather in IRC, you are working on a large project surrounding form data serialization and newlines, and so probably it'd be best to wait on reviews until that's settled and you have a writeup somewhere explaining the desired behavior? |
Although I ran into this as part of working on whatwg/url#562, these tests (other than the ones that deal with filenames) reflect the spec-mandated behavior: setting a string or a Since the parts dealing with |
In that case it's probably fine to review and merge as-is. That will make any future reviews for changes related to I will assign @tkent-google then, but @tkent-google feel free to say you would rather have someone else review; I realize you did not sign up to review this directory in general. |
So the (bare) "filename" tests don't agree with the spec as it is right now, but would agree with any change to the spec that would fix whatwg/url#562. But the "FormData filename" tests might depend on the specifics of that fix. So on second thought, it'd be best to remove those or make them tentative for now. |
No description provided.