[selectors] Add test for :focus-visible and Shadow DOM #28131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This test comes from a discussion on the CSSWG. This needs changes on the spec before merging, so I'm not asking for a review on this yet. |
emilio
requested changes
Apr 20, 2021
mrego
force-pushed
the
focus-visible-shadow-dom
branch
from
f319327
to
060ed69
Compare
|
Thanks for the review @emilio, uploaded new version applying the suggested changes. |
emilio
approved these changes
Apr 20, 2021
This test check that :focus-visible doesn't match on the ShadowRoot, otherwise UAs would end up showing two focus indicators.
mrego
force-pushed
the
focus-visible-shadow-dom
branch
from
060ed69
to
975341b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test check that :focus-visible doesn't match on the
ShadowRoot, otherwise UAs would end up showing two focus indicators.