Add a WPT to check for standards mode plugin document #29264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 7, 2021
The [1] PR will change the standard so that plugin documents are in standard (no quirks) mode. This CL adds a test, as much as this is testable. Some UAs display PDF documents using "content that uses plugins" [2] while others use "inline content that doesn't have a DOM [3]. This test will pass in either case. Chromium already made this change in code in Sept 2020 (see CLs on crbug.com/1131185) and found no compat issues. [1] whatwg/html#6745 [2] https://html.spec.whatwg.org/#read-plugin [3] https://html.spec.whatwg.org/#read-ua-inline Bug: 1131185 Change-Id: Iccd1668199ac8b3b1c90a69b97a0adbaf8d02655
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2944721
branch
from
c4802ee
to
288e4f9
Compare
3 tasks
|
Close this PR because the Chromium CL has been abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The [1] PR will change the standard so that plugin documents
are in standard (no quirks) mode. This CL adds a test, as
much as this is testable. Some UAs display PDF documents
using "content that uses plugins" [2] while others use
"inline content that doesn't have a DOM [3]. This test will
pass in either case.
Chromium already made this change in code in Sept 2020
(see CLs on crbug.com/1131185) and found no compat
issues.
[1] whatwg/html#6745
[2] https://html.spec.whatwg.org/#read-plugin
[3] https://html.spec.whatwg.org/#read-ua-inline
Bug: 1131185
Change-Id: Iccd1668199ac8b3b1c90a69b97a0adbaf8d02655
Reviewed-on: https://chromium-review.googlesource.com/2944721
WPT-Export-Revision: bd363be8c360879cf3e4680fa8085fde26e2f656