Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css selectors :has error recovery test #32200

Conversation

romainmenke
Copy link
Contributor

@romainmenke romainmenke commented Dec 27, 2021

https://drafts.csswg.org/selectors/#relational

:has() takes a forgiving selector list.

Chromium has support for :has() in querySelector and family but this does not support forgiving selector lists.

Test copied over and modified from : css/selectors/is-where-error-recovery.html

@romainmenke
Copy link
Contributor Author

@fantasai If there is anything I can do to move this along, please let me know :)
Want to make sure WPT covers the spec a bit more now that implementations are starting.

@romainmenke romainmenke changed the title css selectors : has error recovery test css selectors :has error recovery test Jun 7, 2022
@romainmenke
Copy link
Contributor Author

@tabatkins Maybe you have a moment to check this?

I can imagine that a similar test might be submitted via chromium as I see that they now correctly handle this (since 104?). If so, I can close this one.

@byung-woo
Copy link
Contributor

Currently, some tests may cover error recovery by testing for disallowed cases (e.g. nested :has()), but IMHO, it would be good to have explicit test to check error recovery.

@tabatkins tabatkins merged commit daaa300 into web-platform-tests:master Jun 17, 2022
@romainmenke romainmenke deleted the css-selectors-has-error-recovery--passionate-spadefoot-toad-14958286f6 branch June 17, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants