Fix modal-dialog-in-table-column.html & modal-dialog-in-replaced-rend… #32947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erer.html to match Gecko & WebKit behavior Gecko & WebKit do not generate boxes for modal dialogs in replaced renderers, and nothing in the spec really says this is the wanted behavior. Blink follows the 'reparent in box tree' logic, but it can be argued that since no box is generated in the first place (like for display: none), there is nothing to reparent, hence no box should be displayed. This is the consensus of a CSSWG meeting: w3c/csswg-drafts#6939 (comment)
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham and
zqzhang
emilio
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erer.html to match Gecko & WebKit behavior
Gecko & WebKit do not generate boxes for modal dialogs in replaced renderers, and nothing in the spec really says this is the wanted behavior.
Blink follows the 'reparent in box tree' logic, but it can be argued that since no box is generated in the first place (like for display: none),
there is nothing to reparent, hence no box should be displayed.
This is the consensus of a CSSWG meeting: w3c/csswg-drafts#6939 (comment)