deriveBits and deriveKey tests #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewers for this pull request are: @Ms2ger, @wafflespeanut, @engelke, and @jimsch. |
|
Critic review: https://critic.hoppipolla.co.uk/r/6705 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
…sts into derive_bits_keys
|
@jimsch this is waiting on review |
| Object.keys(sizes).forEach(function(namedCurve) { | ||
| // Basic success case | ||
| promise_test(function(test) { | ||
| return subtle.deriveBits({name: "ECDH", namedCurve: namedCurve, public: publicKeys[namedCurve]}, privateKeys[namedCurve], 8 * sizes[namedCurve]) |
There was a problem hiding this comment.
namedCurve does not appear to be a used field. Should it be removed?
There was a problem hiding this comment.
Yes it should, and has been for deriveBits now.
There was a problem hiding this comment.
And now also for deriveKeys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests for subtleCrypto deriveBits and deriveKey methods for all all supported algorithms (ECDH, HKDF, PBKDF2).