Bump mypy from 0.812 to 0.931 in /tools #33082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [mypy](https://github.com/python/mypy) from 0.812 to 0.931. - [Release notes](https://github.com/python/mypy/releases) - [Commits](python/mypy@v0.812...v0.931) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
This: * Deals with changes in how mypy handles metaclasses * Prefers sys.platform == "win32" due to python/mypy#8166 and mypy not having WindowsError defined by default any more * Installs various typestubs * Rewrites tox.ini to avoid duplicating everything, and allowing new versions of Python to be easily tested (as tox -e py310-mypy will now work without further changes).
This is clearly capable of hiding issues, such as that in gitignore
wpt-pr-bot
added
gitignore
manifest
mypy.ini
tox.ini
webdriver
wg-testing_browser
labels
foolip
reviewed
Mar 7, 2022
foolip
reviewed
Mar 7, 2022
|
|
||
| return rv # type: ignore | ||
| # type: (Type[ManifestItemMeta], str, Tuple[type], Dict[str, Any]) -> ManifestItemMeta | ||
| inst = super(ManifestItemMeta, cls).__new__(cls, name, bases, attrs) |
There was a problem hiding this comment.
This is the most complicated change made here. The original errors were:
tools/manifest/item.py:38: error: "ManifestItemMeta" has no attribute "item_type" [attr-defined]
tools/manifest/item.py:39: error: "ManifestItemMeta" has no attribute "item_type" [attr-defined]
tools/manifest/item.py:39: error: Incompatible types in assignment (expression has type "ManifestItemMeta", target has type "Type[ManifestItem]") [assignment]
tools/manifest/item.py:41: error: Unused "type: ignore" comment
The fix seems fine to me, I don't know that it could be simplified other than by silencing some errors.
foolip
approved these changes
Mar 7, 2022
This was referenced Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps mypy from 0.812 to 0.931.
Commits
4486d76Bump version to 0.931d7fe756Restore removed builtin_type() api method (#11932)4d64557stubtest: fix literal type construction (#11931)5b3280eFix crash onErasedTypeandcovers_at_runtime(#11924)73de602Stricter None handling with --no-strict-optional (#11717)221a7f3Fix PEP 585 type aliases in stubs (#11918)b40c3d0HandleNoReturntype aliases (#11912)3f2143dAlways allow use oftype[T]in stubs (#11863)12290deBump version to 0.931+dev8ce64ac[0.931 backport] Fix reduce regression (#11866)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)