Don't render top layer elements in non-renderable subtrees #34169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 23, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3646687
branch
from
2207bf8
to
fd3294b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3646687
branch
from
fd3294b
to
b0ea540
Compare
In [1] we started rendering modal dialog elements even if they were in non-renderable subtrees. In [2] this was overturned by the other browsers, so this patch stops rendering them again. [1] https://bugs.webkit.org/attachment.cgi?id=181812&action=review [2] b64788f Fixed: 1301716 Change-Id: I16b7eaf867848d144a7eab743e8ce0af416ce49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3646687 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1016932}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3646687
branch
from
b0ea540
to
e7ea64b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In [1] we started rendering modal dialog elements even if they were in
non-renderable subtrees. In [2] this was overturned by the other
browsers, so this patch stops rendering them again.
[1] https://bugs.webkit.org/attachment.cgi?id=181812&action=review
[2] b64788f
Fixed: 1301716
Change-Id: I16b7eaf867848d144a7eab743e8ce0af416ce49c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3646687
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016932}