Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test wake lock transient activation #36152

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Test wake lock transient activation #36152

wants to merge 6 commits into from

Conversation

marcoscaceres
Copy link
Contributor

No description provided.

@marcoscaceres marcoscaceres mentioned this pull request Sep 29, 2022
Open
4 tasks
reillyeon
reillyeon requested changes Sep 30, 2022
View reviewed changes
screen-wake-lock/wakelock-request-transient-activation.https.html Outdated
];
const locks = await Promise.all(lockPromises);
await Promise.all(locks.map((lock) => lock.release()));
}, "Requesting with a wake requires and consumed transient activation");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this given your comment here about not consuming user activation: w3c/screen-wake-lock#351 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reillyeon reillyeon reillyeon requested changes

@Honry Honry Awaiting requested review from Honry

@rakuco rakuco Awaiting requested review from rakuco

Requested changes must be addressed to merge this pull request.

Assignees

@reillyeon reillyeon

Labels
screen-wake-lock wg-das
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoscaceres @reillyeon @wpt-pr-bot