Change popover invoking attributes #38701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 24, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4288730
branch
from
8ed599b to
ba7b446
Compare
See [1] for discussion. This changes the Popover invoking attribute behavior. Previously, three attributes were used to set the invoking relationship and behavior: - popovertoggletarget - popovershowtarget - popoverhidetarget Those each could point to an idref for a popover, and the behavior would be controlled by which attribute was used. However, there was a confusing situation in the case that multiple such attributes were used on a single element, and even more so when they pointed to different elements. While there was concrete logic for resolving that situation, it was confusing at best. The new logic is controlled by two attributes: - popovertarget - popovertargetaction The element reference is dictated by `popovertarget`, via an idref or through element reflection (via `foo.popoverTargetElement = bar`). The behavior is dictated by the (string valued) popovertargetaction attribute, which can be one of "toggle", "show", or "hide". If any other value is used (including missing attribute or invalid value), the behavior and IDL reflected value is "toggle". [1] whatwg/html#8894 (comment) Bug: 1307772 Change-Id: I2e530efe26032599f9376c8d5f4fe2a7f430a26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4288730 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1109867}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4288730
branch
from
ba7b446 to
40dbd3d
Compare
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 1, 2023
Instead of popoverhidetarget, popovershowtarget, and popovertoggletarget, we will now have popovertarget and popovertargetaction. The former for targeting an element and the latter for determining what to do with the target. Tests: web-platform-tests/wpt#38701.
4 tasks
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 1, 2023
Instead of popoverhidetarget, popovershowtarget, and popovertoggletarget, we will now have popovertarget and popovertargetaction. The former for targeting an element and the latter for determining what to do with the target. Tests: web-platform-tests/wpt#38701. Fixes #8894.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 3, 2023
Instead of popoverhidetarget, popovershowtarget, and popovertoggletarget, we will now have popovertarget and popovertargetaction. The former for targeting an element and the latter for determining what to do with the target. Tests: web-platform-tests/wpt#38701. Fixes #8894.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 7, 2023
Instead of popoverhidetarget, popovershowtarget, and popovertoggletarget, we will now have popovertarget and popovertargetaction. The former for targeting an element and the latter for determining what to do with the target. Tests: web-platform-tests/wpt#38701. Fixes #8894.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 8, 2023
Instead of popoverhidetarget, popovershowtarget, and popovertoggletarget, we will now have popovertarget and popovertargetaction. The former for targeting an element and the latter for determining what to do with the target. This also corrects popover validity checks in activation behavior and consistifies the popover attribute. Tests: web-platform-tests/wpt#38701. HTML-AAM: w3c/html-aam#446. Fixes #8894, fixes #8983, and fixes #8979.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See [1] for discussion. This changes the Popover invoking attribute
behavior. Previously, three attributes were used to set the invoking
relationship and behavior:
Those each could point to an idref for a popover, and the behavior
would be controlled by which attribute was used. However, there was
a confusing situation in the case that multiple such attributes
were used on a single element, and even more so when they pointed
to different elements. While there was concrete logic for resolving
that situation, it was confusing at best.
The new logic is controlled by two attributes:
The element reference is dictated by
popovertarget, via an idrefor through element reflection (via
foo.popoverTargetElement = bar).The behavior is dictated by the (string valued) popovertargetaction
attribute, which can be one of "toggle", "show", or "hide". If any
other value is used (including missing attribute or invalid value),
the behavior and IDL reflected value is "toggle".
[1] whatwg/html#8894 (comment)
Bug: 1307772
Change-Id: I2e530efe26032599f9376c8d5f4fe2a7f430a26b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4288730
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1109867}