[webnn] Add float32 tests for WebNN elu op #39428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
approved these changes
Apr 17, 2023
| } | ||
| }, | ||
| "options": { | ||
| "alpha": -3.468180406374035 |
There was a problem hiding this comment.
I was worried about subtraction of potentially nearly equal numbers in max(0, x) + alpha * (exp(min(0, x)) - 1) , but then I realized that if x is negative, the left part is 0, and if x is positive, the right part of 0. So, LGTM. 👍
Honry
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fdwr @Honry @dontcallmedom PTAL, thanks.