[webnn] Add float32 tests for WebNN linear op #39429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
reviewed
Apr 19, 2023
| } | ||
| }, | ||
| "options": { | ||
| "beta": 5.919095653700928 |
There was a problem hiding this comment.
Beware adding a mix of negative and positive numbers for beta, as you could get catastrophic cancellation. Adding positive beta to positive inputs or negative beta to negative inputs should ensure your ULP tolerance is valid.
Same with next two cases after this.
There was a problem hiding this comment.
Also done to update test data to avoid catastrophic cancellation, please take another look, thanks! @fdwr
BruceDai
force-pushed
the
add_webnn_linear_tests
branch
from
b6e384d
to
4d6144b
Compare
fdwr
approved these changes
Apr 20, 2023
Honry
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fdwr @Honry @dontcallmedom PTAL, thanks.