Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPT] Use sourceDocument for prefetch record lookup #39518

Merged
merged 1 commit into from
May 8, 2023

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 13, 2023

WPT updates for WICG/nav-speculation#267:

  • Updated the expected behavior for an existing test:
    prerender/prefetch.https.html.
  • Added other prefetch test cases.

Except for "<a>" subtest, sourceDocument is different from
navigable's active document.

Chromium's status:

  • "<a>" subtest - already passing
  • Others -- failing. Some of them will pass after [1],
    and remaining failures after [1] are tracked by
    https://crbug.com/1432886.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/4372403

Bug: 1440607, 1432886, 1422815, WICG/nav-speculation#267
Change-Id: I4098347c42f45188811700fcc8d7925bcc3c4162
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4422475
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1141005}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [WPT] Use sourceDocument instead of navigable for non-preloading navigation [WPT] Use sourceDocument for non-preloading navigation Apr 13, 2023
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [WPT] Use sourceDocument for non-preloading navigation [WPT] Use sourceDocument for non-prerendering navigation Apr 17, 2023
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-4422475 branch 2 times, most recently from 3992b12 to ce9ded3 Compare April 17, 2023 07:17
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [WPT] Use sourceDocument for non-prerendering navigation [WPT] Use sourceDocument for prefetch record lookup Apr 17, 2023
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-4422475 branch 2 times, most recently from 3fb9aa8 to 8d10daa Compare April 20, 2023 03:50
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-4422475 branch 2 times, most recently from 2d65d51 to 4011a2b Compare April 20, 2023 04:20
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-4422475 branch 3 times, most recently from 943d424 to 147df06 Compare May 1, 2023 07:13
WPT updates for WICG/nav-speculation#267:

- Updated the expected behavior for an existing test:
  `prerender/prefetch.https.html`.
- Added other prefetch test cases.

Except for "<a>" subtest, `sourceDocument` is different from
`navigable's active document`.

Chromium's status:

- "<a>" subtest - already passing
- Others -- failing. Some of them will pass after [1],
  and remaining failures after [1] are tracked by
  https://crbug.com/1432886.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/4372403

Bug: 1440607, 1432886, 1422815, WICG/nav-speculation#267
Change-Id: I4098347c42f45188811700fcc8d7925bcc3c4162
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4422475
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1141005}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants