Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change WPT test for offset-path parsing #40120

Merged
merged 1 commit into from
May 30, 2023

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 22, 2023

  1. As per https://drafts.csswg.org/css-box-4/#typedef-coord-box
    <coord-box> can't be defined with margin-box.

  2. "at <position" changes come from
    [css-shapes-1] Optional values shouldn't be serialized w3c/csswg-drafts#8695 (comment)

Resolved here: web-platform-tests/interop#340

Change-Id: I6fe865d5248c7004257cd17669353d810f6e3d09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4551246
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150434}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-4551246 branch from 6e248ec to f93bb08 Compare May 22, 2023 10:15
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-4551246 branch from f93bb08 to 24cf850 Compare May 26, 2023 07:59
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Fix wpt test for offset-path parsing Change WPT test for offset-path parsing May 26, 2023
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-4551246 branch 5 times, most recently from 8d88b66 to 62119b5 Compare May 30, 2023 08:33
1) As per https://drafts.csswg.org/css-box-4/#typedef-coord-box
<coord-box> can't be defined with margin-box.

2) "at <position" changes come from
w3c/csswg-drafts#8695 (comment)

Resolved here: web-platform-tests/interop#340

Change-Id: I6fe865d5248c7004257cd17669353d810f6e3d09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4551246
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150434}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants