Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSTransitionDiscrete: implement transition-animation-type #40551

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 14, 2023

This is being discussed here:
w3c/csswg-drafts#8857
The name and values of the property are still under discussion.

This patch does not implement the transition shorthand integration, I'm
going to do that next.

Fixed: 1450870
Bug: 1453112
Change-Id: I808cf6bc090ca0f99229eb4a9d9c3c28ccf22afc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616155
Commit-Queue: Robert Flack <flackr@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168211}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title CSSTransitionDiscrete: implement transition-property-type CSSTransitionDiscrete: implement transition-animation-type Jun 20, 2023
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-4616155 branch 6 times, most recently from 69b723e to b32836f Compare June 29, 2023 21:03
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-4616155 branch 2 times, most recently from 23e584c to c6b2a8f Compare July 10, 2023 17:21
This is being discussed here:
w3c/csswg-drafts#8857
The name and values of the property are still under discussion.

This patch does not implement the transition shorthand integration, I'm
going to do that next.

Fixed: 1450870
Bug: 1453112
Change-Id: I808cf6bc090ca0f99229eb4a9d9c3c28ccf22afc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616155
Commit-Queue: Robert Flack <flackr@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168211}
@WeizhongX
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test Subtest Results Messages
/css/css-content/content-no-interpolation.html   OK: 9/10, TIMEOUT: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions: property from [initial] to ["b"] at (-0.3) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions: property from [initial] to ["b"] at (0) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions: property from [initial] to ["b"] at (0.3) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions: property from [initial] to ["b"] at (0.5) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions: property from [initial] to ["b"] at (0.6) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions: property from [initial] to ["b"] at (1) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions: property from [initial] to ["b"] at (1.5) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions with transition: all: property from [initial] to ["b"] at (-0.3) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions with transition: all: property from [initial] to ["b"] at (0) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions with transition: all: property from [initial] to ["b"] at (0.3) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions with transition: all: property from [initial] to ["b"] at (0.5) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions with transition: all: property from [initial] to ["b"] at (0.6) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions with transition: all: property from [initial] to ["b"] at (1) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Transitions with transition: all: property from [initial] to ["b"] at (1.5) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Animations: property from [initial] to ["b"] at (-0.3) should be [initial] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Animations: property from [initial] to ["b"] at (0) should be [initial] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Animations: property from [initial] to ["b"] at (0.3) should be [initial] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Animations: property from [initial] to ["b"] at (0.5) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Animations: property from [initial] to ["b"] at (0.6) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Animations: property from [initial] to ["b"] at (1) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html CSS Animations: property from [initial] to ["b"] at (1.5) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html Web Animations: property from [initial] to ["b"] at (-0.3) should be [initial] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html Web Animations: property from [initial] to ["b"] at (0) should be [initial] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html Web Animations: property from [initial] to ["b"] at (0.3) should be [initial] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html Web Animations: property from [initial] to ["b"] at (0.5) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html Web Animations: property from [initial] to ["b"] at (0.6) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html Web Animations: property from [initial] to ["b"] at (1) should be ["b"] PASS: 9/10, MISSING: 1/10  
/css/css-content/content-no-interpolation.html Web Animations: property from [initial] to ["b"] at (1.5) should be ["b"] PASS: 9/10, MISSING: 1/10  

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

@WeizhongX
Copy link
Contributor

submit crbug.com/1464305. @jcscottiii @KyleJu can you help admin merge this? thanks!

@KyleJu KyleJu merged commit cb9e7c8 into master Jul 12, 2023
@KyleJu KyleJu deleted the chromium-export-cl-4616155 branch July 12, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants