-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSSTransitionDiscrete: implement transition-animation-type #40551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
29474e4
to
11c6d68
Compare
11c6d68
to
87bc395
Compare
69b723e
to
b32836f
Compare
23e584c
to
c6b2a8f
Compare
This is being discussed here: w3c/csswg-drafts#8857 The name and values of the property are still under discussion. This patch does not implement the transition shorthand integration, I'm going to do that next. Fixed: 1450870 Bug: 1453112 Change-Id: I808cf6bc090ca0f99229eb4a9d9c3c28ccf22afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616155 Commit-Queue: Robert Flack <flackr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1168211}
c6b2a8f
to
a6258ba
Compare
WPT Command: Some affected tests had inconsistent (flaky) results: Unstable results
These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag |
submit crbug.com/1464305. @jcscottiii @KyleJu can you help admin merge this? thanks! |
This is being discussed here:
w3c/csswg-drafts#8857
The name and values of the property are still under discussion.
This patch does not implement the transition shorthand integration, I'm
going to do that next.
Fixed: 1450870
Bug: 1453112
Change-Id: I808cf6bc090ca0f99229eb4a9d9c3c28ccf22afc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616155
Commit-Queue: Robert Flack <flackr@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168211}