Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct worker test for unsupported: scheme #41758

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Correct worker test for unsupported: scheme #41758

merged 2 commits into from
Sep 5, 2023

Conversation

annevk
Copy link
Member

@annevk annevk commented Sep 1, 2023

Identified in #41745.

@annevk annevk requested a review from youennf September 1, 2023 08:28
@wpt-pr-bot wpt-pr-bot requested review from caitp, jdm and zqzhang September 1, 2023 08:28
@annevk
Copy link
Member Author

annevk commented Sep 1, 2023

Any other tests that are broken?

@annevk annevk mentioned this pull request Sep 1, 2023
Open
@annevk
Copy link
Member Author

annevk commented Sep 1, 2023

I guess I should add a test for a URL that does fail to parse so we have something that fails synchronously.

annevk added a commit to whatwg/html that referenced this pull request Sep 1, 2023
@annevk
Bundle workers with script execution
4176692 
In particular, if you can execute script, you can execute a worker. Making workers an optional feature is not actually something user agents implement and has led to implementer confusion, e.g., web-platform-tests/wpt#41758.
@annevk annevk mentioned this pull request Sep 1, 2023
Merged
4 tasks
annevk added a commit to whatwg/html that referenced this pull request Sep 4, 2023
@annevk
No longer allow a policy exception just for workers
6ca960a 
In particular, if you can execute script, you can execute a worker. Making workers an optional feature is not actually something user agents implement and has led to implementer confusion, e.g., web-platform-tests/wpt#41758.
noamr
noamr approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@noamr noamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you want to wait for one of the assigned reviewers be my guest!

@annevk annevk merged commit 2d504ed into master Sep 5, 2023
@annevk annevk deleted the annevk/worker-unsupported branch September 5, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamr noamr noamr approved these changes

@youennf youennf Awaiting requested review from youennf

@caitp caitp Awaiting requested review from caitp

@jdm jdm Awaiting requested review from jdm

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@zqzhang zqzhang

Labels
wg-s_htmlwg workers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annevk @noamr @zqzhang @wpt-pr-bot