Enable shadowrealm testing for abort api #41965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's block on this as per #41985. |
ptomato
force-pushed
the
rwaldron/shadowrealm-dom-abort-api-tests
branch
from
a9fd16e to
af5a589
Compare
|
Rebased and added some additional changes since |
ptomato
reviewed
Dec 11, 2023
49 tasks
AbortSignal.timeout() isn't exposed in ShadowRealm environments, so it shouldn't be tested there. Split it out into a separate file, and add another file for ShadowRealm environments testing that the property is not present.
ptomato
force-pushed
the
rwaldron/shadowrealm-dom-abort-api-tests
branch
from
af5a589 to
83c4541
Compare
annevk
approved these changes
Oct 22, 2024
|
Was going to try to merge this at the same time as #41985, but looks like that one needs some more discussion. So I'll go ahead and merge this one. Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.