Avoid asserting default sizes in {progress,meter}-native-computed-style.optional.html writing mode tests #41997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le.optional.html writing mode tests These tests currently assume that the default inline and block sizes of <progress> and <meter> are the same across all browsers. That is not the case, and is irrelevant to the purpose of the test, which is to assert that the block size should match height/width and inline size should match width/height depending on the writing mode. Replace the exact value assertions with assertions that test for an appropriate aspect ratio (inline size greater than block size).
wpt-pr-bot
requested review from
fantasai,
kojiishi,
plinss,
r12a and
upsuper
|
cc @nt1m |
nt1m
approved these changes
Sep 15, 2023
OrKoN
pushed a commit
that referenced
this pull request
Sep 18, 2023
…le.optional.html writing mode tests (#41997) These tests currently assume that the default inline and block sizes of <progress> and <meter> are the same across all browsers. That is not the case, and is irrelevant to the purpose of the test, which is to assert that the block size should match height/width and inline size should match width/height depending on the writing mode. Replace the exact value assertions with assertions that test for an appropriate aspect ratio (inline size greater than block size).
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
…le.optional.html writing mode tests (web-platform-tests#41997) These tests currently assume that the default inline and block sizes of <progress> and <meter> are the same across all browsers. That is not the case, and is irrelevant to the purpose of the test, which is to assert that the block size should match height/width and inline size should match width/height depending on the writing mode. Replace the exact value assertions with assertions that test for an appropriate aspect ratio (inline size greater than block size).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests currently assume that the default inline and block sizes of and are the same across all browsers. That is not the case, and is irrelevant to the purpose of the test, which is to assert that the block size should match height/width and inline size should match width/height depending on the writing mode.
Replace the exact value assertions with assertions that test for an appropriate aspect ratio (inline size greater than block size).