Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=235065 #43028

Merged

Conversation

joone
Copy link
Contributor

@joone joone commented Nov 8, 2023

WebKit export from bug: AX: HTML AAM Update to aside mapping

@wpt-pr-bot
Copy link
Collaborator

This patch has been exported from WebKit; it will be approved automatically once the downstream patch is r+.

@twilco
Copy link
Contributor

twilco commented Nov 9, 2023

cc @sivakusayan who opened #43013 recently. Does this look OK to you @sivakusayan?

@sivakusayan
Copy link
Contributor

Yeah, this looks good to me 🙂

I was originally going to add a role case to #43013 as well, but I thought people would feel weird about adding role attributes in HTML-AAM tests (since we're testing ARIA in a folder testing native semantics). But I guess one could argue that we're testing that the conditional mapping only applies to native complementary elements, and not ARIA complementary elements. So if others are okay with it I'm okay with it too.

Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor test name change, but deferring to scott on this one. it might need another HTML-AAM update too.

html-aam/roles-contextual.html Show resolved Hide resolved
@cookiecrook
Copy link
Contributor

minor test name change, but deferring to scott on this one. it might need another HTML-AAM update too.

I think we can probably accept this as-is as a downstream export, and update the test name in the later PR:

@cookiecrook cookiecrook merged commit 72b8ea6 into web-platform-tests:master Nov 9, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants