Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create accname/name/comp_labelledby_hidden_nodes.html #43043

Merged
merged 17 commits into from
Nov 16, 2023
Merged

Create accname/name/comp_labelledby_hidden_nodes.html #43043

merged 17 commits into from
Nov 16, 2023

Conversation

rahimabdi
Copy link
Contributor

@rahimabdi rahimabdi commented Nov 9, 2023 •
edited
Loading

WPT test as an action item from accName comp step 2B note referenced in:

Tests the following requirement in comp_labelledby:

The result of LabelledBy Recursion in combination with Hidden Not Referenced means that user agents MUST include all nodes in the subtree as part of the accessible name or accessible description, when the node referenced by aria-labelledby or aria-describedby is hidden.

Closes: web-platform-tests/interop-accessibility#77

@rahimabdi rahimabdi assigned cookiecrook and unassigned MelSumner Nov 9, 2023
@rahimabdi rahimabdi mentioned this pull request Nov 13, 2023
Closed
cookiecrook
cookiecrook requested changes Nov 14, 2023
View reviewed changes
accname/name/comp_labelledby_hidden_nodes.html Outdated Show resolved Hide resolved
accname/name/comp_labelledby_hidden_nodes.html Outdated Show resolved Hide resolved
accname/name/comp_labelledby_hidden_nodes.html Outdated Show resolved Hide resolved
accname/name/comp_labelledby_hidden_nodes.html Outdated Show resolved Hide resolved
accname/name/comp_labelledby_hidden_nodes.html Outdated Show resolved Hide resolved
accname/name/comp_labelledby_hidden_nodes.html Outdated Show resolved Hide resolved
accname/name/comp_labelledby_hidden_nodes.html Outdated Show resolved Hide resolved
accname/name/comp_labelledby_hidden_nodes.html Outdated Show resolved Hide resolved
accname/name/comp_labelledby_hidden_nodes.html Outdated Show resolved Hide resolved
accname/name/comp_labelledby_hidden_nodes.html Outdated Show resolved Hide resolved
rahimabdi and others added 12 commits November 14, 2023 15:11
@rahimabdi @cookiecrook
Update to remove redundant visibility:hidden
b9e197a 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@rahimabdi @cookiecrook
Update to remove more redundant visibility:hidden nodes
ec480c0 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@rahimabdi @cookiecrook
Update to remove another redundant visibility:hidden node
fa56fef 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@rahimabdi @cookiecrook
Update to remove remaining redundant visibility:hidden nodes
6502f6b 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@rahimabdi @cookiecrook
Update to remove remaining redundant aria-hidden nodes
dc9d60a 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@rahimabdi @cookiecrook
Removing redundant HTML5 hidden attribute
15967af 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@rahimabdi @cookiecrook
Removing more redundant HTML5 hidden attribute
66ccb44 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@rahimabdi @cookiecrook
Removing another redundant HTML5 hidden attribute
2484312 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@rahimabdi @cookiecrook
Removing remaining redundant HTML5 hidden attribute
f8662e7 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
Update tests to remove redundant markup for hiding content, fixed ind…
cacd368 
…entation
Fix test names for consistency
870b4a6
Fix extra tag brackets, ensure correct markup
1acaa01
cookiecrook
cookiecrook approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 🚀

@rahimabdi rahimabdi merged commit 24a4390 into master Nov 16, 2023
@rahimabdi rahimabdi deleted the rahim/comp-labelledby-hidden-nodes-test branch November 16, 2023 17:28
@rahimabdi rahimabdi mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cookiecrook cookiecrook cookiecrook approved these changes

@jnurthen jnurthen Awaiting requested review from jnurthen

@MelSumner MelSumner Awaiting requested review from MelSumner

@spectranaut spectranaut Awaiting requested review from spectranaut

Assignees

@cookiecrook cookiecrook

Labels
accname
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write tests for accName 2B note ("LabelledBy Recursion in combination with Hidden Not Referenced")
5 participants
@rahimabdi @cookiecrook @MelSumner @wpt-pr-bot @moz-wptsync-bot