[webnn] Add float32 tests for WebNN API expand op #43559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
reviewed
Dec 8, 2023
| @@ -660,10 +661,11 @@ const buildPad = (operationName, builder, resources) => { | |||
| }; | |||
|
|
|||
| const buildReshape = (operationName, builder, resources) => { | |||
| // MLOperand reshape(MLOperand input, sequence<unsigned long?> newShape); | |||
| // MLOperand reshape(MLOperand input, sequence<unsigned long> newShape); | |||
There was a problem hiding this comment.
Hmm, what does this commented line mean? Does it mean you're implementing that API function here? If so, suggest adding that to the comment:
// Implements:
// MLOperand reshape(MLOperand input, sequence<unsigned long> newShape);
// MLOperand reshape(MLOperand input, sequence<unsigned long> newShape);
There was a problem hiding this comment.
I removed '?' character since Chromium CL#5060264 - Drop null value support in newShape parameter for reshape has already been merged, link to webmachinelearning/webnn#388.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fdwr @Honry @mei1127 @fujunwei PTAL, thanks.