Remove aria-relevant tests #43866
Remove aria-relevant tests #43866
Conversation
This attribute was removed from the ARIA spec in 2020: see w3c/aria#1261 and w3c/aria#1267.
wpt-pr-bot
requested review from
annevk,
foolip,
hayatoito,
jdm,
jgraham,
jnurthen,
joanmarie,
kojiishi,
michael-n-cooper,
rniwa,
snuggs,
spectranaut and
TakayoshiKochi
|
@cookiecrook @alice thoughts? |
|
Hm, looks like committing w3c/aria#1261 with |
|
from the diff in w3c/aria#1261
So not an accident. 1267 still unresolved. I think you were looking at 1265 not 1267? |
| @@ -58,7 +58,6 @@ | |||
| "ariaPosInSet", | |||
| "ariaPressed", | |||
| "ariaReadOnly", | |||
| "ariaRelevant", | |||
There was a problem hiding this comment.
I'd prefer to comment this one with a pointer to the issue: https://github.com/w3c/aria/issue/1267
There was a problem hiding this comment.
- "ariaRelevant",
+ // "ariaRelevant", // blocked by https://github.com/w3c/aria/issue/1267| @@ -47,7 +47,6 @@ | |||
| testReflectAttribute('ariaPosInSet', 'aria-posinset', 'foo', 'bar', 'ariaPosInSet on Element'); | |||
| testReflectAttribute('ariaPressed', 'aria-pressed', 'foo', 'bar', 'ariaPressed on Element'); | |||
| testReflectAttribute('ariaReadOnly', 'aria-readonly', 'foo', 'bar', 'ariaReadOnly on Element'); | |||
| testReflectAttribute('ariaRelevant', 'aria-relevant', 'foo', 'bar', 'ariaRelevant on Element'); | |||
There was a problem hiding this comment.
Ditto here. These are alphabetical lists, so they should include all the known properties, even if some aren't testable yet.
We used a similar pattern in html-aam/roles.html for completeness and pointers to avoid duplication of tests or issues.
There was a problem hiding this comment.
- testReflectAttribute('ariaRelevant', 'aria-relevant', 'foo', 'bar', 'ariaRelevant on Element');
+ // ariaRelevant blocked by https://github.com/w3c/aria/issue/1267There was a problem hiding this comment.
"they should include all the known properties"
How do you define "known properties"? Looking at published specs, I can find nothing that would give me knowledge of ariaRelevant.
Did you mean instead "specified and proposed-for-the-future properties"?
This attribute was removed from the ARIA spec in 2020: see w3c/aria#1261 and w3c/aria#1267.
All browsers will fail the new -historical.html tests, so it's not clear whether we should merge this or fix the spec...