Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apng that uses cICP #43980

Merged
merged 4 commits into from
Jan 21, 2024
Merged

Add apng that uses cICP #43980

merged 4 commits into from
Jan 21, 2024

Conversation

svgeesus
Copy link
Contributor

Each frame inherits every property specified by any critical or ancillary chunks before the first IDAT chunk in the file

Test image has IHDR, cICP, acTL, IDAT, fcTL, fdAT, IEND

cICP is 12, 13, 0, 1 ie Display P3

Animation has one frame, static image is not part of the animation.

The static image is P3 red, the first frame in the fdAT is srgb lime converted to Display P3.
sRGB lime = color(display-p3 0.4584 0.9853 0.2983)

So the displayed result should be sRGB lime, converted back from Display P3

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request besides its author. Please reach out on the chat room to get help with this. Thank you!

@svgeesus
Copy link
Contributor Author

@ProgramMax I thought that you had been added as a reviewer for WPT PNG tests, but it seems not.

Copy link
Contributor

@ProgramMax ProgramMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-OWNER LGTM

@svgeesus svgeesus mentioned this pull request Jan 12, 2024
@svgeesus
Copy link
Contributor Author

@ProgramMax you are listed here as a reviewer, maybe it needs some other permission as well.

@svgeesus svgeesus requested a review from foolip January 13, 2024 13:54
@svgeesus
Copy link
Contributor Author

@foolip @jgraham sorry to keep bothering you like this, could we get an owner approval please?

@svgeesus
Copy link
Contributor Author

@annevk perhaps you could review?

@annevk
Copy link
Member

annevk commented Jan 18, 2024

@svgeesus you should ask on the Matrix chat to get @ProgramMax added as a committer.

@svgeesus svgeesus merged commit b68d58f into web-platform-tests:master Jan 21, 2024
19 checks passed
@svgeesus svgeesus deleted the apng-cicp branch January 21, 2024 13:27
marcoscaceres pushed a commit that referenced this pull request Feb 23, 2024
* add apng that uses cICP

* add set timeout exception for new APNG test

* Use stable URL for spec link

* typo, add .html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants