Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accname/name/comp_host_language_label.html with hidden label tests #44183

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rahimabdi
Copy link
Contributor

@MelSumner
Copy link
Contributor

I'm a little confused about this one. I thought that there was existing, explicit language that a hidden label does not provide a valid name for an input, but these tests seem to suggest that browsers support the opposite. What am I missing here? I could use a brief chat on this one, I think.

@cookiecrook
Copy link
Contributor

cookiecrook commented Mar 29, 2024

Yes, and I am concerned that this diff greatly increases the Chrome/Gecko failure percentages of a file included in an Interop 2024 Focus Area. Perhaps we can start by adding any new tests that fail to a new .tentative file (so they don't affect the Interop score), and then consider the subtests one by one. In particular the promise rejections are likely b/c the test is calling for computedlabel on unrendered elements, which may be exposing a legitimate implementation detail that should not be tested in the meantime.

Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in convo tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants