Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebDriver BiDi worker tests #44291

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Add WebDriver BiDi worker tests #44291

merged 1 commit into from
Feb 6, 2024

Conversation

jrandolf-2
Copy link
Contributor

@jrandolf-2 jrandolf-2 commented Jan 30, 2024

This PR adds tests for all worker realms.

Note we can't truly test realm destroyed service worker realms since that is implementation dependent.

@OrKoN
Copy link
Contributor

OrKoN commented Jan 31, 2024

@sadym-chromium could you please review?

@jrandolf-2 jrandolf-2 marked this pull request as draft January 31, 2024 22:29
@jrandolf-2
Copy link
Contributor Author

Let's hold off on this. Blocked on w3c/webdriver-bidi#651

@jrandolf-2 jrandolf-2 marked this pull request as ready for review February 5, 2024 15:59
@jrandolf-2
Copy link
Contributor Author

No longer blocked. @sadym-chromium Please review.

Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/cFm3DbcQSW6MvBC0T5fNvQ/d7CGc9kRQ4OX6bnfX2IXcg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/cFm3DbcQSW6MvBC0T5fNvQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/cFm3DbcQSW6MvBC0T5fNvQ/d7CGc9kRQ4OX6bnfX2IXcg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/cFm3DbcQSW6MvBC0T5fNvQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-02-06T15:16:22.520Z

@jrandolf-2 jrandolf-2 enabled auto-merge (rebase) February 6, 2024 15:18
@jrandolf-2
Copy link
Contributor Author

@web-platform-tests/admins Could someone force merge this PR?

@sideshowbarker sideshowbarker merged commit 33b559d into master Feb 6, 2024
18 of 21 checks passed
@sideshowbarker sideshowbarker deleted the jrandolf/worker branch February 6, 2024 17:50
mbrodesser-Igalia pushed a commit to mbrodesser-Igalia/wpt that referenced this pull request Feb 19, 2024
marcoscaceres pushed a commit that referenced this pull request Feb 23, 2024
moz-wptsync-bot pushed a commit that referenced this pull request Oct 28, 2024
Originally introduced in #44291, but this is wrong, as it completely ignores the provided source for the script.

Differential Revision: https://phabricator.services.mozilla.com/D226770

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1914407
gecko-commit: 59ae3c80d4f7b91dfc6b128c9cec05994de45f36
gecko-reviewers: webdriver-reviewers, whimboo
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 29, 2024
…river-reviewers,whimboo

Originally introduced in web-platform-tests/wpt#44291, but this is wrong, as it completely ignores the provided source for the script.

Differential Revision: https://phabricator.services.mozilla.com/D226770
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Oct 29, 2024
…river-reviewers,whimboo

Originally introduced in web-platform-tests/wpt#44291, but this is wrong, as it completely ignores the provided source for the script.

Differential Revision: https://phabricator.services.mozilla.com/D226770
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this pull request Oct 30, 2024
…river-reviewers,whimboo

Originally introduced in web-platform-tests/wpt#44291, but this is wrong, as it completely ignores the provided source for the script.

Differential Revision: https://phabricator.services.mozilla.com/D226770
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Nov 1, 2024
…river-reviewers,whimboo

Originally introduced in web-platform-tests/wpt#44291, but this is wrong, as it completely ignores the provided source for the script.

Differential Revision: https://phabricator.services.mozilla.com/D226770

UltraBlame original commit: 59ae3c80d4f7b91dfc6b128c9cec05994de45f36
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Nov 1, 2024
…river-reviewers,whimboo

Originally introduced in web-platform-tests/wpt#44291, but this is wrong, as it completely ignores the provided source for the script.

Differential Revision: https://phabricator.services.mozilla.com/D226770

UltraBlame original commit: 59ae3c80d4f7b91dfc6b128c9cec05994de45f36
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Nov 1, 2024
…river-reviewers,whimboo

Originally introduced in web-platform-tests/wpt#44291, but this is wrong, as it completely ignores the provided source for the script.

Differential Revision: https://phabricator.services.mozilla.com/D226770

UltraBlame original commit: 59ae3c80d4f7b91dfc6b128c9cec05994de45f36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants