-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebDriver BiDi worker tests #44291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AutomatedTester,
jgraham,
juliandescottes,
sadym-chromium,
shs96c and
whimboo
January 30, 2024 15:03
OrKoN
removed request for
shs96c,
AutomatedTester,
whimboo,
jgraham and
juliandescottes
January 31, 2024 17:10
@sadym-chromium could you please review? |
Let's hold off on this. Blocked on w3c/webdriver-bidi#651 |
jrandolf-2
force-pushed
the
jrandolf/worker
branch
from
February 5, 2024 15:59
bdeadd7
to
9ffaa26
Compare
No longer blocked. @sadym-chromium Please review. |
jrandolf-2
force-pushed
the
jrandolf/worker
branch
from
February 6, 2024 13:11
9ffaa26
to
d617dd9
Compare
jrandolf-2
force-pushed
the
jrandolf/worker
branch
from
February 6, 2024 14:42
d617dd9
to
f0f9f7f
Compare
Lightning00Blade
approved these changes
Feb 6, 2024
Uh oh! Looks like an error! DetailsClient ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
jrandolf-2
force-pushed
the
jrandolf/worker
branch
from
February 6, 2024 15:18
f0f9f7f
to
2eb1124
Compare
@web-platform-tests/admins Could someone force merge this PR? |
mbrodesser-Igalia
pushed a commit
to mbrodesser-Igalia/wpt
that referenced
this pull request
Feb 19, 2024
marcoscaceres
pushed a commit
that referenced
this pull request
Feb 23, 2024
moz-wptsync-bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
Originally introduced in #44291, but this is wrong, as it completely ignores the provided source for the script. Differential Revision: https://phabricator.services.mozilla.com/D226770 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1914407 gecko-commit: 59ae3c80d4f7b91dfc6b128c9cec05994de45f36 gecko-reviewers: webdriver-reviewers, whimboo
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 29, 2024
…river-reviewers,whimboo Originally introduced in web-platform-tests/wpt#44291, but this is wrong, as it completely ignores the provided source for the script. Differential Revision: https://phabricator.services.mozilla.com/D226770
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Oct 29, 2024
…river-reviewers,whimboo Originally introduced in web-platform-tests/wpt#44291, but this is wrong, as it completely ignores the provided source for the script. Differential Revision: https://phabricator.services.mozilla.com/D226770
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 30, 2024
…river-reviewers,whimboo Originally introduced in web-platform-tests/wpt#44291, but this is wrong, as it completely ignores the provided source for the script. Differential Revision: https://phabricator.services.mozilla.com/D226770
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 1, 2024
…river-reviewers,whimboo Originally introduced in web-platform-tests/wpt#44291, but this is wrong, as it completely ignores the provided source for the script. Differential Revision: https://phabricator.services.mozilla.com/D226770 UltraBlame original commit: 59ae3c80d4f7b91dfc6b128c9cec05994de45f36
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 1, 2024
…river-reviewers,whimboo Originally introduced in web-platform-tests/wpt#44291, but this is wrong, as it completely ignores the provided source for the script. Differential Revision: https://phabricator.services.mozilla.com/D226770 UltraBlame original commit: 59ae3c80d4f7b91dfc6b128c9cec05994de45f36
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 1, 2024
…river-reviewers,whimboo Originally introduced in web-platform-tests/wpt#44291, but this is wrong, as it completely ignores the provided source for the script. Differential Revision: https://phabricator.services.mozilla.com/D226770 UltraBlame original commit: 59ae3c80d4f7b91dfc6b128c9cec05994de45f36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for all worker realms.
Note we can't truly test realm destroyed service worker realms since that is implementation dependent.