Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to account for links wrapped in svg #44461

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Test to account for links wrapped in svg #44461

merged 1 commit into from
Feb 8, 2024

Conversation

Ahmad-S792
Copy link
Contributor

Hi Team,

This test is to look account for UA stylesheet rules of visited links for links in SVG.

I copied the current test and added svg wrapper around links and added link to GitHub issue from SVGWG GitHub.

Currently, both Firefox and Chrome passes this but Safari fails but I am planning to fix but wanted to do WPT test before hand.

Thanks!

Hi Team,

This test is to look account for `UA` stylesheet rules of visited links for links in SVG.

I copied the current test and added `svg` wrapper around links and added link to GitHub issue from SVGWG GitHub.

Currently, both Firefox and Chrome passes this but Safari fails but I am planning to fix but wanted to do WPT test before hand.

Thanks!
@sideshowbarker
Copy link
Member

Diff against the existing no-help-cursor-on-links.historical.html test:

--- html/rendering/the-css-user-agent-style-sheet-and-presentational-hints/no-help-cursor-on-links.historical.html	2020-02-10 10:19:48.055592299 +0900
+++ html/rendering/the-css-user-agent-style-sheet-and-presentational-hints/no-help-cursor-on-links-wrapped-in-svg.historical.html	2024-02-09 03:49:43.791650234 +0900
@@ -5,12 +5,14 @@
 <script src="/resources/testharnessreport.js"></script>

 <link rel="help" href="https://html.spec.whatwg.org/#phrasing-content-3">
-<link rel="help" href="https://github.com/whatwg/html/pull/3902">
+<link rel="help" href="https://github.com/w3c/svgwg/issues/468">

 <div id="log"></div>

+<svg>
 <a href="/common/blank.html?unvisited" rel="help" id="unvisited">unvisited</a>
 <a href="/common/blank.html?willbevisited" rel="help" id="willbevisited">will be visited</a>
+</svg>

 <script>
 "use strict";

@sideshowbarker sideshowbarker merged commit 11f539a into web-platform-tests:master Feb 8, 2024
20 checks passed
@Ahmad-S792 Ahmad-S792 deleted the svg-link-test-case branch February 8, 2024 19:04
mbrodesser-Igalia pushed a commit to mbrodesser-Igalia/wpt that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants