Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage for webkit prefixed historical interface #44462

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Add coverage for webkit prefixed historical interface #44462

merged 1 commit into from
Feb 8, 2024

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Feb 8, 2024

Hi Team,

It was supported by Safari / WebKit until recently and it was removed days ago, I think it would be good to add coverage for it.

Thanks!

Hi Team,

It was supported by Safari / WebKit until recently and it was removed weeks ago, I think it would be good to add coverage for it.

Thanks!
@Ahmad-S792 Ahmad-S792 self-assigned this Feb 8, 2024
@Ahmad-S792 Ahmad-S792 requested a review from saschanaz February 8, 2024 02:57
@wpt-pr-bot wpt-pr-bot requested review from jdm and NavidZ February 8, 2024 02:57
@Ahmad-S792
Copy link
Contributor Author

WebKit Commit - WebKit/WebKit@f50de88

Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you are coming from https://bugs.webkit.org/show_bug.cgi?id=267813. r+ 👍

@saschanaz
Copy link
Member

Do you have the merge permission?

@Ahmad-S792
Copy link
Contributor Author

Do you have the merge permission?

I don't think I have.

@saschanaz saschanaz merged commit 54a180f into web-platform-tests:master Feb 8, 2024
19 checks passed
@saschanaz
Copy link
Member

I did it, thanks!

@Ahmad-S792 Ahmad-S792 deleted the more-historical-stuff-ui-events branch February 8, 2024 08:44
@Ahmad-S792
Copy link
Contributor Author

I did it, thanks!

Thanks! Another historical cruft coverage now in WPT. :-)

@saschanaz
Copy link
Member

BTW you probably should have the permission, maybe talk to Anne to get one.

@Ahmad-S792
Copy link
Contributor Author

BTW you probably should have the permission, maybe talk to Anne to get one.

Yup! Will reach out to him. :-)

mbrodesser-Igalia pushed a commit to mbrodesser-Igalia/wpt that referenced this pull request Feb 19, 2024
…-tests#44462)

Hi Team,

It was supported by Safari / WebKit until recently and it was removed weeks ago, I think it would be good to add coverage for it.

Thanks!
marcoscaceres pushed a commit that referenced this pull request Feb 23, 2024
Hi Team,

It was supported by Safari / WebKit until recently and it was removed weeks ago, I think it would be good to add coverage for it.

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants