Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply SVG paint-order to text-decorations #44511

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Apply SVG paint-order to text-decorations #44511

merged 1 commit into from
Feb 15, 2024

Conversation

Ahmad-S792
Copy link
Contributor

Hi Team,

This is test case from Blink Commit:

Commit - https://chromium.googlesource.com/chromium/blink/+/72eecba077f756ef4ed254541ff37dcb9baec05a

I noticed that WebKit / Safari was failing so I wanted to do merge but it was suggested that if this can be uploaded to WPT, it would be better for coverage for all browsers.

Credits to Blink Developer / Engineer (fs@opera.com).

Thanks!

Hi Team,

This is test case from Blink Commit:

Commit - https://chromium.googlesource.com/chromium/blink/+/72eecba077f756ef4ed254541ff37dcb9baec05a

I noticed that WebKit / Safari was failing so I wanted to do merge but it was
suggested that if this can be uploaded to WPT, it would be better for coverage
for all browsers.

Credits to Blink Developer / Engineer (fs@opera.com).

Thanks!
@Ahmad-S792
Copy link
Contributor Author

For reference - here I am merging Blink commit into WebKit to align all browsers - WebKit/WebKit#23960

@Ahmad-S792
Copy link
Contributor Author

@fsoder - Appreciate if you can review this?

Copy link
Contributor

@fsoder fsoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even remember writing these test - thanks for exporting them (will have to remember to dedupe in Blink)! 👍

@Ahmad-S792 Ahmad-S792 merged commit 57308ed into web-platform-tests:master Feb 15, 2024
19 checks passed
@Ahmad-S792 Ahmad-S792 deleted the test-blink-paintorder-on-text-decoration branch March 11, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants