Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc wpt: add test for direction-based filtering of codecs #44604

Merged
merged 1 commit into from
Feb 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions webrtc/protocol/codecs-filtered-by-direction.https.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
<!doctype html>
<meta charset=utf-8>
<meta name="timeout" content="long">
<title>RTCPeerConnection Codecs in offer get filtered by direction</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="../third_party/sdp/sdp.js"></script>
<script>
'use strict';

function codecEquals(c1, c2) {
return c1.mimeType === c2.mimeType &&
c1.sdpFmtpLine === c2.sdpFmtpLine &&
c1.clockRate === c2.clockRate &&
c1.channels === c2.channels;
}

function splitCodecs() {
const sendCodecs = RTCRtpSender.getCapabilities('video').codecs;
const receiveCodecs = RTCRtpReceiver.getCapabilities('video').codecs;
const codecs = {
sendrecv: [],
sendonly: [],
recvonly: [],
};
// Ignore RTX since it is present in capabilities once and has no apt.
for (const receiveCodec of receiveCodecs) {
if (receiveCodec.mimeType === 'video/rtx') continue;
if (sendCodecs.find(sendCodec => codecEquals(sendCodec, receiveCodec))) {
codecs.sendrecv.push(receiveCodec);
}
}

for (const sendCodec of sendCodecs) {
if (sendCodec.mimeType === 'video/rtx') continue;
if (!receiveCodecs.find(receiveCodec => codecEquals(sendCodec, receiveCodec))) {
codecs.sendonly.push(sendCodec);
}
}
for (const receiveCodec of receiveCodecs) {
if (receiveCodec.mimeType === 'video/rtx') continue;
if (!sendCodecs.find(sendCodec => codecEquals(sendCodec, receiveCodec))) {
codecs.recvonly.push(receiveCodec);
}
}
return codecs;
}

promise_test(async t => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());

const allCodecs = splitCodecs();
const transceiver = pc.addTransceiver('video');

transceiver.direction = 'sendonly'
const offer = await pc.createOffer();
const mediaSection = SDPUtils.getMediaSections(offer.sdp)[0];
const rtpParameters = SDPUtils.parseRtpParameters(mediaSection);
const sendonlyCodecs = rtpParameters.codecs.filter(c => c.name !== 'rtx');
assert_equals(sendonlyCodecs.length, allCodecs.sendrecv.length + allCodecs.sendonly.length);
}, 'Codecs get filtered by direction for sendonly');

promise_test(async t => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());

const allCodecs = splitCodecs();
const transceiver = pc.addTransceiver('video');

transceiver.direction = 'recvonly'
const offer = await pc.createOffer();
const mediaSection = SDPUtils.getMediaSections(offer.sdp)[0];
const rtpParameters = SDPUtils.parseRtpParameters(mediaSection);
const recvonlyCodecs = rtpParameters.codecs.filter(c => c.name !== 'rtx');
assert_equals(recvonlyCodecs.length, allCodecs.sendrecv.length + allCodecs.recvonly.length);
}, 'Codecs get filtered by direction for recvonly');

</script>
Loading