Test priority of cICP over iCCP #44644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no reviewers for this pull request besides its author. Please reach out on the chat room to get help with this. Thank you! |
|
LGTM, except for the lint error. It says you need a link to the spec. You have two, though. I'm not sure why it doesn't recognize them. |
|
Yeah I don't understand the lint error either, especially as it mentions an entirely unrelated spec:
|
|
@web-platform-tests/wpt-core-team any help on resolving this apparently unrelated lint error? |
|
Rebase to the latest |
|
@ProgramMax you have been added to the reviewer pool, please approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PNG Third edition says:
The test file is a PNG with solid sRGB green (0, 128, 0) converted to Display P3 (0.21603749037034126, 0.49418159073224005, 0.13151307826427636). The image has a Display P3
cICPchunk. It also has aniCCPchunk containing a modified sRGB ICC profile; the red and green colorants are swapped so, if used, the result will be a deep red.The test HTML also starts with a solid red, in case the image is not loaded at all.
The reference uses an sRGB PNG which is sRGB green (0, 128, 0).