Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM: Added a few batch-insertion scenarios that are incompatible across engines #44658

Merged
merged 31 commits into from
Feb 29, 2024
Merged

DOM: Added a few batch-insertion scenarios that are incompatible across engines #44658

merged 31 commits into from
Feb 29, 2024

Commits on Feb 29, 2024

  1. Test inserting a script and a div from a DocumentFragment 

    The test follows the spec, but the spec is followed only by Safari.
    @nox @domfarolino
    nox authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    dd49336 View commit details
    Browse the repository at this point in the history

  2. Test inserting a script and a custom element 

    This test too follows the spec, but only Safari defines the custom element
before inserting one in the document, other browsers upgrade the custom-element
at the time of the customElements.define call because it is already in tree.
    @nox @domfarolino
    nox authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    b8c4374 View commit details
    Browse the repository at this point in the history

  3. Test inserting a script and button in a form from a div 

    This test once again follows the spec, but only Safari executes it correctly,
with no form owner set on the button at the time of the execution of the
script.
    @nox @domfarolino
    nox authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    05694a9 View commit details
    Browse the repository at this point in the history

  4. Test inserting three scripts where the first one modifies the third one 

    Safari and Chrome pass that test, Firefox fails it.
    @nox @domfarolino
    nox authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    6e602f6 View commit details
    Browse the repository at this point in the history

  5. Test inserting two text nodes from a fragment into an empty script el… 

    …ement
    @nox @domfarolino
    nox authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    8a43ca1 View commit details
    Browse the repository at this point in the history

  6. Test inserting text and script nodes in a style element

    @nox @domfarolino
    nox authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    11214ff View commit details
    Browse the repository at this point in the history

  7. Test inserting a script and a style where the script modifies the style

    @nox @domfarolino
    nox authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    631c9ac View commit details
    Browse the repository at this point in the history

  8. Test inserting a script and some code in an empty script

    @nox @domfarolino
    nox authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    2ddd125 View commit details
    Browse the repository at this point in the history

  9. Test inserting a script and an iframe both at the same time

    @nox @domfarolino
    nox authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7643207 View commit details
    Browse the repository at this point in the history

  10. Test inserting a script and a stylesheet link both at the same time

    @nox @domfarolino
    nox authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    66357e1 View commit details
    Browse the repository at this point in the history

  11. Test inserting a script and a source in a media element

    @nox @domfarolino
    nox authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d104e23 View commit details
    Browse the repository at this point in the history

  12. Test inserting a script and a default-style meta

    @nox @domfarolino
    nox authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    1e52f0f View commit details
    Browse the repository at this point in the history

  13. rewrite first four files to work again

    @annevk @domfarolino
    annevk authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    ae30cc5 View commit details
    Browse the repository at this point in the history

  14. more

    @annevk @domfarolino
    annevk authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    392eed7 View commit details
    Browse the repository at this point in the history

  15. wip

    @annevk @domfarolino
    annevk authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    a339b35 View commit details
    Browse the repository at this point in the history

  16. more cleanup

    @annevk @domfarolino
    annevk authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    982a1f4 View commit details
    Browse the repository at this point in the history

  17. Fix a couple of tests to have more coherent results

    @noamr @domfarolino
    noamr authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    55767c7 View commit details
    Browse the repository at this point in the history

  18. Add .tentative

    @noamr @domfarolino
    noamr authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    3ee6105 View commit details
    Browse the repository at this point in the history

  19. Change expected results to match batch insertion

    @noamr @domfarolino
    noamr authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d598cb5 View commit details
    Browse the repository at this point in the history

  20. Update dom/nodes/insertion-effects/Node-appendChild-script-and-button… 

    …-from-div.tentative.html

Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
    @noamr @domfarolino
    noamr and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    68ee4c1 View commit details
    Browse the repository at this point in the history

  21. Update dom/nodes/insertion-effects/Node-appendChild-script-and-styles… 

    …heet-link-from-fragment.tentative.html

Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
    @noamr @domfarolino
    noamr and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    b8c3dd0 View commit details
    Browse the repository at this point in the history

  22. Apply suggestions from code review 

    Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
    @noamr @domfarolino
    noamr and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    70b0596 View commit details
    Browse the repository at this point in the history

  23. Remove redundant log divs

    @noamr @domfarolino
    noamr authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    e5eaa85 View commit details
    Browse the repository at this point in the history

  24. Apply PR fixes

    @noamr @domfarolino
    noamr authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7da6f2d View commit details
    Browse the repository at this point in the history

  25. Some changes

    @domfarolino
    domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4573bb4 View commit details
    Browse the repository at this point in the history

  26. Fix assertion

    @domfarolino
    domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    6bfc45b View commit details
    Browse the repository at this point in the history

  27. Combine tests

    @domfarolino
    domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5a010df View commit details
    Browse the repository at this point in the history

  28. Update expectations for style tests

    @noamr @domfarolino
    noamr authored and domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d7174e5 View commit details
    Browse the repository at this point in the history

  29. Write explicit test description and combine a few more tests

    @domfarolino
    domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    98aa182 View commit details
    Browse the repository at this point in the history

  30. Move to insertion-removing-steps

    @domfarolino
    domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    76b9cb2 View commit details
    Browse the repository at this point in the history

  31. Unnecessary src assignment

    @domfarolino
    domfarolino committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    f818763 View commit details
    Browse the repository at this point in the history