Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebNN: Implement MLBuffer dispatch #45632

Merged
merged 1 commit into from
May 6, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 9, 2024

Adds support to execute MLGraphs using MLBuffers. Allows the WebNN
developer to directly bind MLBuffers as input/outputs to graphs
for execution, which keeps MLBuffer data on-device after execution
completes. In future CLs, dispatch can be further optimized.

  • Moves out per graph resources required by Dispatch().
  • MLGraphBuilder.build no longer pre-allocates I/O.

webmachinelearning/webnn#482

Bug: 1472888
Change-Id: I7400704cf60c149c47c20f22c50d5f12bff89cf9
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5173678
Reviewed-by: Austin Sullivan <asully@chromium.org>
Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1296971}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-5173678 branch 8 times, most recently from eb6ad9c to 0ba00d3 Compare April 17, 2024 17:54
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-5173678 branch 5 times, most recently from 99b74bd to 9807579 Compare May 6, 2024 16:40
@chromium-wpt-export-bot chromium-wpt-export-bot marked this pull request as ready for review May 6, 2024 18:19
Adds support to execute MLGraphs using MLBuffers. Allows the WebNN
developer to directly bind MLBuffers as input/outputs to graphs
for execution, which keeps MLBuffer data on-device after execution
completes. In future CLs, dispatch can be further optimized.

* Moves out per graph resources required by Dispatch().
* MLGraphBuilder.build no longer pre-allocates I/O.

webmachinelearning/webnn#482

Bug: 1472888
Change-Id: I7400704cf60c149c47c20f22c50d5f12bff89cf9
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5173678
Reviewed-by: Austin Sullivan <asully@chromium.org>
Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1296971}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit eca5b25 into master May 6, 2024
18 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-5173678 branch May 6, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants