Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove invalid namefrom contents expectations for td #45870

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook commented Apr 24, 2024

Closes web-platform-tests/interop-accessibility#119

Previous label tests assumed ARIA namefrom:contents was available on cell roles... There is an open w3c/aria#2160 that might clarify this, but for Interop 2024, these few test test expectations did not match the current HTML-AAM spec, so we're removing them.

<td data-expectedrole="cell" data-expectedlabel="x" data-testname="td as child of tr with display: contents, within table with display: flex, has cell role" class="ex-role-and-label">x</td>
<td data-expectedrole="cell" data-testname="td as child of tr with display: contents, within table with display: flex, has cell role" class="ex-role">x</td>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@nmlapre nmlapre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for doing this.

@cookiecrook cookiecrook merged commit d21ae82 into web-platform-tests:master Apr 24, 2024
19 checks passed
@cookiecrook cookiecrook deleted the invalid-td-name-from-contents branch April 24, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix acc label expectations for td elements in display-contents-role-and-label.html
4 participants