Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payment Request: use remote origin instead for policy test #47015

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Payment Request: use remote origin instead for policy test #47015

merged 1 commit into from
Jul 10, 2024

Conversation

marcoscaceres
Copy link
Contributor

No description provided.

@marcoscaceres marcoscaceres requested a review from rsolomakhin July 5, 2024 05:20
@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you!

@marcoscaceres marcoscaceres changed the title Payment Request: use remote host instead for policy test Payment Request: use remote origin instead for policy test Jul 5, 2024
@marcoscaceres marcoscaceres enabled auto-merge (squash) July 9, 2024 01:23
@rsolomakhin rsolomakhin requested review from stephenmcgruer and removed request for rsolomakhin July 10, 2024 10:39
stephenmcgruer
stephenmcgruer approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@stephenmcgruer stephenmcgruer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little surprised that REMOTE_ORIGIN uses a hardcoded www1 string in get_host_info(), but definitely better to use this common helper than doing it ourselves, and the tests still appear to pass so LGTM!

@marcoscaceres marcoscaceres merged commit 1087e9f into master Jul 10, 2024
19 checks passed
@marcoscaceres marcoscaceres deleted the pay branch July 10, 2024 15:30
sadym-chromium pushed a commit that referenced this pull request Jul 18, 2024
@marcoscaceres @sadym-chromium
Payment Request: use remote origin instead for policy test (#47015)
4c0c325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmcgruer stephenmcgruer stephenmcgruer approved these changes

Assignees
No one assigned
Labels
permissions-policy status:needs-reviewers wg-s_webappsec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoscaceres @wpt-pr-bot @stephenmcgruer