[FedCM] Send SameSite=Lax cookies, in addition to None #47065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion in w3c-fedid/FedCM#587 This is behind the FedCmSameSiteLax flag for now. Bug: 350944661 Change-Id: I3e5fe99b98560f680217cd3326ff66d290a5290f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5675433 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1325570}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5675433
branch
from
e4807d7 to
cbe2ecf
Compare
wpt-pr-bot
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in w3c-fedid/FedCM#587
This is behind the FedCmSameSiteLax flag for now.
Bug: 350944661
Change-Id: I3e5fe99b98560f680217cd3326ff66d290a5290f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5675433
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1325570}